The following layout test is flaky on Mojave inspector/page/overrideSetting-ICECandidateFilteringEnabled.html Probable cause: Test was introduced in https://trac.webkit.org/changeset/240644/webkit and is a flakey timeout. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fpage%2FoverrideSetting-ICECandidateFilteringEnabled.html
<rdar://problem/48008005>
Created attachment 363171 [details] Patch Not really sure why it's flaky, but I ran it a few hundred times on my machine (WK1 and WK2) and it seemed to work better
Comment on attachment 363171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363171&action=review rs=me > LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:24 > + delete pc.onicecandidate; Just set it to null instead of delete?
Comment on attachment 363171 [details] Patch Clearing flags on attachment: 363171 Committed r242231: <https://trac.webkit.org/changeset/242231>
All reviewed patches have been landed. Closing bug.
This test is still timing out on Mojave WK1 about 1 in every 4 runs on the dashboard. Also is timing out on Mojave Wk2, but not nearly as consistently. Was able to reproduce locally with : run-webkit-tests inspector/page/overrideSetting-ICECandidateFilteringEnabled.html --iterations 500 -f -1 Produced 22 failures. run-webkit-tests inspector/page/overrideSetting-ICECandidateFilteringEnabled.html --iterations 500 -f Produced 9 failures. Flakiness Dashboard : https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fpage%2FoverrideSetting-ICECandidateFilteringEnabled.html
Reopening based on Shawn's comment above.
Created attachment 367060 [details] Patch It seems like the main issue was with the first part of the test. Removing it made it pass without issue on 1000+ iterations on my machine. I've also enabled debug logging just in case it still fails so we can hopefully get more information as to why.
Comment on attachment 367060 [details] Patch r=me
Comment on attachment 367060 [details] Patch Clearing flags on attachment: 367060 Committed r244280: <https://trac.webkit.org/changeset/244280>
This is still showing intermittent failures. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fpage%2FoverrideSetting-ICECandidateFilteringEnabled.html
Created attachment 369754 [details] Patch It seems like the failure occurs after the first "part" of the test. Given that the second "part" doesn't really add anything new (e.g. the first "part" goes from filtering enabled to disabled, while the second "part" does the opposite), I think it's fine to remove.
Comment on attachment 369754 [details] Patch rs=me
Comment on attachment 369754 [details] Patch Clearing flags on attachment: 369754 Committed r245363: <https://trac.webkit.org/changeset/245363>