Bug 194436 – Export MathML fraction tests to WPT

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Frédéric Wang (:fredw)]

We have several reftests for fractions that can be exported to WPT.
Some of the tests have equivalent (and more reliable testing) in WPT and can be removed.
Others that just verify crashs/asserts, hangs or invalid markup and be moved up to LayoutTests/mathml/

[Frédéric Wang (:fredw)]

Created attachment 362733 [details]
Patch

[EWS Watchlist]

Comment on attachment 362733 [details]
Patch

Attachment 362733 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11249329

New failing tests:
imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html
imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html

[EWS Watchlist]

Created attachment 362743 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Frédéric Wang (:fredw)]

Created attachment 362744 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 362744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362744&action=review

LGTM, but I'd update the ChangeLog message before landing.

> LayoutTests/imported/w3c/ChangeLog:6
> +        This is just an import of the current MathML WPT tests. It includes fraction tests from

This is not accurate, this is not only an import, you're also exporting some tests here.

[Frédéric Wang (:fredw)]

Comment on attachment 362744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362744&action=review

>> LayoutTests/imported/w3c/ChangeLog:6
>> +        This is just an import of the current MathML WPT tests. It includes fraction tests from
> 
> This is not accurate, this is not only an import, you're also exporting some tests here.

Yes, but this is explained in the other ChangeLog.

[Rob Buis]

Comment on attachment 362744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362744&action=review

LGTM as well.

> LayoutTests/ChangeLog:7


crashes.

[Frédéric Wang (:fredw)]

Created attachment 362980 [details]
Patch

[Frédéric Wang (:fredw)]

@Rego, @Rob: Same patch uploaded with tweaks in the ChangeLogs.

[Manuel Rego Casasnovas]

Comment on attachment 362980 [details]
Patch

Ok, I thought I did r+ the other day sorry.

[WebKit Commit Bot]

Comment on attachment 362980 [details]
Patch

Rejecting attachment 362980 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 362980, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/11290374

[Frédéric Wang (:fredw)]

Committed r242085: <https://trac.webkit.org/changeset/242085>

[Radar WebKit Bug Importer]

<rdar://problem/48400036>