Bug 194434 - [ESNext] Implement private methods
Summary: [ESNext] Implement private methods
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords:
Depends on: 174212
Blocks: 194435
  Show dependency treegraph
 
Reported: 2019-02-08 05:43 PST by Caio Lima
Modified: 2019-10-15 05:57 PDT (History)
3 users (show)

See Also:


Attachments
WIP - Patch (80.57 KB, patch)
2019-05-27 08:55 PDT, Caio Lima
no flags Details | Formatted Diff | Diff
Patch (122.68 KB, patch)
2019-06-27 13:48 PDT, Caio Lima
no flags Details | Formatted Diff | Diff
Patch (115.62 KB, patch)
2019-10-14 00:24 PDT, Caio Lima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2019-02-08 05:43:24 PST
The proposal https://tc39.github.io/proposal-private-methods/ is on Stage 3.
Comment 1 Caio Lima 2019-05-27 08:55:23 PDT
Created attachment 370694 [details]
WIP - Patch

This patch is dependent on changes from https://bugs.webkit.org/show_bug.cgi?id=174212.
Comment 2 Caio Lima 2019-06-27 13:48:10 PDT
Created attachment 373050 [details]
Patch

This Patch does not apply to tree, since it is a diff from patch on https://bugs.webkit.org/show_bug.cgi?id=174212.
Comment 3 Caio Lima 2019-10-14 00:24:27 PDT
Created attachment 380859 [details]
Patch

This patch is the diff of private methods on top of class fields patch.
Comment 4 Ross Kirsling 2019-10-15 05:57:35 PDT
Comment on attachment 380859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380859&action=review

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:3027
> +    if (!m_privateNamesStack.size())
> +        return;

Could this be an assertion?

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:-304
> -

You could probably drop this file if it's just whitespace changes.

> Source/JavaScriptCore/runtime/JSSymbolTableObject.h:45
> -    
> +

Ditto.