Bug 194418 – webkitpy: CrashLogs.find_all_logs may return a string or a dictionary

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Megan Gardner]

When running test editing/deleting/smart-delete-across-editable-boundaries-2.html I get this crash:

AttributeError raised: 'str' object has no attribute 'iteritems'
Traceback (most recent call last):
  File "/Volumes/Data/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 85, in main
    run_details = run(port, options, args, stderr)
  File "/Volumes/Data/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 448, in run
    run_details = manager.run(args)
  File "/Volumes/Data/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 271, in run
    return self._end_test_run(start_time, end_time, initial_results, retry_results, enabled_pixel_tests_in_retry)
  File "/Volumes/Data/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 306, in _end_test_run
    self._look_for_new_crash_logs(initial_results, start_time)
  File "/Volumes/Data/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 381, in _look_for_new_crash_logs
    crash_logs = self._port.look_for_new_crash_logs(crashed_processes, start_time)
  File "/Volumes/Data/WebKit/OpenSource/Tools/Scripts/webkitpy/port/darwin.py", line 159, in look_for_new_crash_logs
    return self._merge_crash_logs(crash_logs, all_crash_log, crashed_processes)
  File "/Volumes/Data/WebKit/OpenSource/Tools/Scripts/webkitpy/port/darwin.py", line 99, in _merge_crash_logs
    for test, crash_log in new_logs.iteritems():
AttributeError: 'str' object has no attribute 'iteritems'

[Jonathan Bedard]

Helped Megan a bit in person with this today.

For some reason, CrashLogs.find_all_logs returns a string in some circumstances, instead of an error. Looking into exactly why before I fix this.

[Jonathan Bedard]

Created attachment 361506 [details]
Patch

[Jonathan Bedard]

I'd actually like Megan to verify that this patch fixes her problem....I think there is some directory missing on her machine (probably would be created if the appropriate crash log were generated), so I can't reproduce this bug.

[Lucas Forschler]

Comment on attachment 361506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361506&action=review

> Tools/ChangeLog:12
> +

This is a very long sentence. Can you break it up to make it more readable? (also extra word 'trying' here)

[Jonathan Bedard]

Created attachment 361518 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 361518 [details]
Patch for landing

Clearing flags on attachment: 361518

Committed r241202: <https://trac.webkit.org/changeset/241202>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47924490>