Bug 194409 – [Web GPU] GPUDevice::createTexture implementation prototype

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Justin Fan]

[Web GPU] GPUDevice::createTexture implementation prototype

[Radar WebKit Bug Importer]

<rdar://problem/47894312>

[Justin Fan]

Created attachment 361432 [details]
Patch

[Justin Fan]

Created attachment 361438 [details]
Patch

[Justin Fan]

Created attachment 361441 [details]
Patch

[Dean Jackson]

Comment on attachment 361441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361441&action=review

> Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:66
> +        if (usage & MTLTextureUsageShaderWrite)

I'm not sure if we should be testing for the MTL form or the GPUTextureUsage::Storage flag. I think the latter makes more sense.

> Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:75
> +    return usage;

Should it be an error (nullopt) to return unknown?

> Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:110
> +    auto usage = mtlTextureUsageForGPUTextureUsageFlags(descriptor.usage);
> +    if (!usage) {

Yeah, so here.... if we're usage type unknown, should we error?

> Source/WebCore/platform/graphics/gpu/cocoa/GPUTextureMetal.mm:111
> +        LOG(WebGPU, "%s: Invalid GPUTextureUsageFlags!");

You forgot functionName. Surprised it compiled.

[Justin Fan]

Created attachment 361474 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 361474 [details]:

media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html bug 193587 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 361474 [details]
Patch for landing

Clearing flags on attachment: 361474

Committed r241181: <https://trac.webkit.org/changeset/241181>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.