Bug 194408 – Web Inspector: Fix modify-css-property-race.html flakiness

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

https://bugs.webkit.org/show_bug.cgi?id=194318#c11:

> After the fixes in https://trac.webkit.org/changeset/241011/webkit
> 
> inspector/css/modify-css-property-race.html
> 
> has become a flakey failure on Debug. Looks like it it somehow writing
> another pass message? 
> 
> History:
> http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=inspector%2Fcss%2Fmodify-css-property-race.html
> 
> Diff:
> ---
> /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/
> inspector/css/modify-css-property-race-expected.txt
> +++
> /Volumes/Data/slave/highsierra-debug-tests-wk1/build/layout-test-results/
> inspector/css/modify-css-property-race-actual.txt
> @@ -7,4 +7,5 @@
>  PASS: Height should have increased from 11px.
>  PASS: Height should be 100px or more.
>  PASS: Height should be 101px or more.
> +PASS: Height should be 101px or more.

[Nikita Vasilyev]

Created attachment 361429 [details]
Patch

Verify that the test is no longer flaky on the debug build:

Tools/Scripts/run-webkit-tests -1 -iterations 500 -f --debug LayoutTests/inspector/css/modify-css-property-race.html

[Devin Rousso]

Comment on attachment 361429 [details]
Patch

rs=me

[WebKit Commit Bot]

Comment on attachment 361429 [details]
Patch

Clearing flags on attachment: 361429

Committed r241144: <https://trac.webkit.org/changeset/241144>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47897050>