Bug 194407 - Overflow element scrollbar is light for dark mode content
Summary: Overflow element scrollbar is light for dark mode content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-07 12:22 PST by Timothy Hatcher
Modified: 2019-02-07 15:34 PST (History)
6 users (show)

See Also:


Attachments
Patch (13.24 KB, patch)
2019-02-07 12:34 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2019-02-07 12:22:40 PST
The overflow case was missed when fixing scrollbars for dark mode FrameViews in https://trac.webkit.org/changeset/237466/webkit.

<rdar://problem/45991585>
Comment 1 Timothy Hatcher 2019-02-07 12:34:59 PST
Created attachment 361428 [details]
Patch
Comment 2 Build Bot 2019-02-07 12:39:21 PST
Attachment 361428 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:409:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2019-02-07 15:34:31 PST
Comment on attachment 361428 [details]
Patch

Clearing flags on attachment: 361428

Committed r241150: <https://trac.webkit.org/changeset/241150>
Comment 4 WebKit Commit Bot 2019-02-07 15:34:33 PST
All reviewed patches have been landed.  Closing bug.