Bug 194393 - Fix responsive design issues for the Contribute menu and Feature Status navigation
Summary: Fix responsive design issues for the Contribute menu and Feature Status navig...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-07 08:20 PST by Jon Davis
Modified: 2019-02-07 16:53 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2019-02-07 08:27 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2019-02-07 08:20:18 PST 
In Safari on macOS, small windows with very short window height and small enough width (just before the menus collapse to a chevron) causes the Contribute drop-down menu to render incorrectly, and the Feature Status and CSS Features navigation do not resize to accommodate wrapped text.
Comment 1 Jon Davis 2019-02-07 08:27:08 PST 
Created attachment 361395 [details]
Patch
Comment 2 Nikita Vasilyev 2019-02-07 11:46:39 PST 
Comment on attachment 361395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361395&action=review

> Websites/webkit.org/wp-content/themes/webkit/style.css:2514
> +@media only screen and (max-height: 415px) and (max-width: 920px) {

Is this for the horizontal mode on iPhone-sized devices?
Comment 3 Jon Davis 2019-02-07 11:58:14 PST 
Yes it is.
Comment 4 Nikita Vasilyev 2019-02-07 12:21:04 PST 
Looks good! I'd r+
Comment 5 Devin Rousso 2019-02-07 16:38:40 PST 
Comment on attachment 361395 [details]
Patch

rs=me
Comment 6 WebKit Commit Bot 2019-02-07 16:52:53 PST 
Comment on attachment 361395 [details]
Patch

Clearing flags on attachment: 361395

Committed r241173: <https://trac.webkit.org/changeset/241173>
Comment 7 WebKit Commit Bot 2019-02-07 16:52:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-02-07 16:53:27 PST 
<rdar://problem/47903067>