Bug 194373 – [iOS] [WK2] Modernize autocorrection context code

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

- Use Delayed instead of LegacySync.
- Package all the autocorrection context info into a single struct, and encode/decode the struct over IPC.

[Wenson Hsieh]

Created attachment 361373 [details]
Patch

[Wenson Hsieh]

Created attachment 361374 [details]
Patch

[Wenson Hsieh]

Created attachment 361393 [details]
Patch

[Wenson Hsieh]

Created attachment 361405 [details]
Actually fix non-iOS builds

[Tim Horton]

Comment on attachment 361405 [details]
Actually fix non-iOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=361405&action=review

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:581
> +WebAutocorrectionContext WebPageProxy::getAutocorrectionContext()

Why "get"?

[Wenson Hsieh]

Comment on attachment 361405 [details]
Actually fix non-iOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=361405&action=review

>> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:581
>> +WebAutocorrectionContext WebPageProxy::getAutocorrectionContext()
> 
> Why "get"?

Only because it was already "get" before! (not a good reason :P)

I'll rename it to autocorrectionContextSync().

[Wenson Hsieh]

Created attachment 361439 [details]
Patch for EWS

[WebKit Commit Bot]

Comment on attachment 361439 [details]
Patch for EWS

Clearing flags on attachment: 361439

Committed r241146: <https://trac.webkit.org/changeset/241146>

[Daniel Bates]

Comment on attachment 361439 [details]
Patch for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=361439&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3398
> +    if (!completionHandler)
> +        return;

Why?!

[Daniel Bates]

Comment on attachment 361439 [details]
Patch for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=361439&action=review

> Source/WebKit/Shared/ios/WebAutocorrectionContext.h:85
> +    return {{ WTFMove(*contextBefore), WTFMove(*markedText), WTFMove(*selectedText), WTFMove(*contextAfter), WTFMove(*location), WTFMove(*length) }};

I really do not like this style....were just playing games. Just decode into the struct.

[Daniel Bates]

Comment on attachment 361439 [details]
Patch for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=361439&action=review

>> Source/WebKit/Shared/ios/WebAutocorrectionContext.h:85
>> +    return {{ WTFMove(*contextBefore), WTFMove(*markedText), WTFMove(*selectedText), WTFMove(*contextAfter), WTFMove(*location), WTFMove(*length) }};
> 
> I really do not like this style....were just playing games. Just decode into the struct.

#WTFMoveEverything <- why?

[Daniel Bates]

Into radar because it trampled over my work.

[Radar WebKit Bug Importer]

<rdar://problem/47938348>

[Daniel Bates]

Comment on attachment 361439 [details]
Patch for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=361439&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3398
>> +        return;
> 
> Why?!

This seems to me to be illogical. Like hell freezes over logical. See bug 194397, comment 8 for more details.