Bug 194366 – Unable to sign in leetcode

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[youenn fablet]

Test that Request constructor throws if FetchRequestInit.signal is not undefined, null or an AbortSignal object

[youenn fablet]

Created attachment 361343 [details]
Patch

[youenn fablet]

Created attachment 361344 [details]
Patch

[youenn fablet]

Created attachment 361346 [details]
Patch

[EWS Watchlist]

Comment on attachment 361346 [details]
Patch

Attachment 361346 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11059517

New failing tests:
imported/w3c/web-platform-tests/fetch/api/abort/general.any.html
imported/w3c/web-platform-tests/fetch/api/abort/general.any.worker.html

[EWS Watchlist]

Created attachment 361355 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361346 [details]
Patch

Attachment 361346 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11059496

New failing tests:
imported/w3c/web-platform-tests/fetch/api/abort/general.any.html
imported/w3c/web-platform-tests/fetch/api/abort/general.any.worker.html

[EWS Watchlist]

Created attachment 361356 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[youenn fablet]

Created attachment 361359 [details]
Patch

[EWS Watchlist]

Comment on attachment 361359 [details]
Patch

Attachment 361359 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11060506

New failing tests:
fast/viewport/ios/device-width-viewport-after-changing-view-scale.html

[EWS Watchlist]

Created attachment 361372 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Chris Dumez]

Comment on attachment 361359 [details]
Patch

r=me

[Alex Christensen]

Comment on attachment 361359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361359&action=review

r=me
Should we propose a loosening change to the fetch spec, or should we indicate that we intend to change this back once the web has updated their polyfills?

> LayoutTests/http/wpt/fetch/request-abort-expected.txt:5
> +FAIL Request from URL with signal assert_throws: function "() => { new Request("/", {signal: "my signal"}) }" did not throw
> +FAIL Request from request with signal assert_throws: function "() => { new Request(request, {signal: "my signal"}) }" did not throw

These tests should probably not print "FAIL" which indicates that there is something yet to fix.

[youenn fablet]

Thanks for the reviews.

(In reply to Alex Christensen from comment #12)
> Comment on attachment 361359 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361359&action=review
> 
> r=me
> Should we propose a loosening change to the fetch spec, or should we
> indicate that we intend to change this back once the web has updated their
> polyfills?

We intend to revert these changes whenever possible.
I'll file a Bugzilla accordingly.

> > LayoutTests/http/wpt/fetch/request-abort-expected.txt:5
> > +FAIL Request from URL with signal assert_throws: function "() => { new Request("/", {signal: "my signal"}) }" did not throw
> > +FAIL Request from request with signal assert_throws: function "() => { new Request(request, {signal: "my signal"}) }" did not throw
> 
> These tests should probably not print "FAIL" which indicates that there is
> something yet to fix.

The idea is to keep the test as is and rebase the test expectation once the C++ changes are reverted.

[WebKit Commit Bot]

Comment on attachment 361359 [details]
Patch

Clearing flags on attachment: 361359

Committed r241137: <https://trac.webkit.org/changeset/241137>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47892805>