Bug 194365 – Web Inspector: Timelines: clicking on an empty space in the overview should deselect any selected record bar

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Once a record becomes selected, it's basically impossible to deselect it.  We should provide a way to deselect that makes sense.

[Radar WebKit Bug Importer]

<rdar://problem/47868426>

[Radar WebKit Bug Importer]

<rdar://problem/47868425>

[Devin Rousso]

<rdar://problem/47868426>

[Devin Rousso]

Created attachment 361425 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 361425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361425&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js:392
> +        // Ensure that the container "click" listener added by `WI.TimelineOverview` isn't called.
> +        event.__timelineRecordBarClick = true;

Can we just stop propagation?

[Devin Rousso]

Comment on attachment 361425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361425&action=review

>> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js:392
>> +        event.__timelineRecordBarClick = true;
> 
> Can we just stop propagation?

My fear with that is that we'd end up breaking some other functionality with the mouse in Timelines.  This approach seems the least likely to cause regressions.

[WebKit Commit Bot]

Comment on attachment 361425 [details]
Patch

Clearing flags on attachment: 361425

Committed r241302: <https://trac.webkit.org/changeset/241302>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.