Bug 194365 - Web Inspector: Timelines: clicking on an empty space in the overview should deselect any selected record bar
Summary: Web Inspector: Timelines: clicking on an empty space in the overview should d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-06 15:55 PST by Devin Rousso
Modified: 2019-02-12 10:22 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.88 KB, patch)
2019-02-07 11:57 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-02-06 15:55:45 PST 
Once a record becomes selected, it's basically impossible to deselect it.  We should provide a way to deselect that makes sense.
Comment 1 Radar WebKit Bug Importer 2019-02-06 15:56:06 PST 
<rdar://problem/47868426>
Comment 2 Radar WebKit Bug Importer 2019-02-06 15:56:17 PST 
<rdar://problem/47868425>
Comment 3 Devin Rousso 2019-02-07 11:51:04 PST 
<rdar://problem/47868426>
Comment 4 Devin Rousso 2019-02-07 11:57:33 PST 
Created attachment 361425 [details]
Patch
Comment 5 Joseph Pecoraro 2019-02-11 12:36:44 PST 
Comment on attachment 361425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361425&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js:392
> +        // Ensure that the container "click" listener added by `WI.TimelineOverview` isn't called.
> +        event.__timelineRecordBarClick = true;

Can we just stop propagation?
Comment 6 Devin Rousso 2019-02-12 09:56:32 PST 
Comment on attachment 361425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361425&action=review

>> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js:392
>> +        event.__timelineRecordBarClick = true;
> 
> Can we just stop propagation?

My fear with that is that we'd end up breaking some other functionality with the mouse in Timelines.  This approach seems the least likely to cause regressions.
Comment 7 WebKit Commit Bot 2019-02-12 10:22:46 PST 
Comment on attachment 361425 [details]
Patch

Clearing flags on attachment: 361425

Committed r241302: <https://trac.webkit.org/changeset/241302>
Comment 8 WebKit Commit Bot 2019-02-12 10:22:47 PST 
All reviewed patches have been landed.  Closing bug.