Bug 194364 - Print backgrounds preference should be honored instead of WKWebViewConfiguration value
Summary: Print backgrounds preference should be honored instead of WKWebViewConfigurat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-06 15:34 PST by Alex Christensen
Modified: 2019-02-07 11:02 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.74 KB, patch)
2019-02-07 10:07 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.86 KB, patch)
2019-02-07 10:59 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-02-06 15:34:51 PST 
Print backgrounds preference should be honored instead of WKWebViewConfiguration value
Comment 1 Alex Christensen 2019-02-07 10:07:02 PST 
Created attachment 361408 [details]
Patch
Comment 2 Tim Horton 2019-02-07 10:46:42 PST 
Comment on attachment 361408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361408&action=review

> Source/WebKit/ChangeLog:15
> +        * UIProcess/API/Cocoa/WKWebView.mm:

You need to explain the long-term cleanup plan either here or in the bug, and there should be a new bug tracking it.
Comment 3 Alex Christensen 2019-02-07 10:59:02 PST 
Created attachment 361419 [details]
Patch
Comment 4 Alex Christensen 2019-02-07 11:01:39 PST 
https://trac.webkit.org/changeset/241131/webkit
Comment 5 Radar WebKit Bug Importer 2019-02-07 11:02:59 PST 
<rdar://problem/47889813>