Bug 194357 - Really enable the automatic checking and regenerations of .xcfilelists during builds
Summary: Really enable the automatic checking and regenerations of .xcfilelists during...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-06 13:09 PST by Keith Rollin
Modified: 2019-02-06 14:55 PST (History)
12 users (show)

See Also:

Attachments
Patch (8.72 KB, patch)
2019-02-06 13:46 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-02-06 13:09:03 PST 
Bug 194124 was supposed to enable the automatic checking and regenerating of .xcfilelist files during the build. While related changes were included in that patch, the change to actually enable the operation somehow was omitted. This patch actually enables the operation. The check-xcfilelist.sh scripts now check WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer from the checking.
Comment 1 Radar WebKit Bug Importer 2019-02-06 13:09:29 PST 
<rdar://problem/47861231>
Comment 2 Keith Rollin 2019-02-06 13:46:16 PST 
Created attachment 361324 [details]
Patch
Comment 3 Chris Dumez 2019-02-06 13:47:48 PST 
Comment on attachment 361324 [details]
Patch

rs=me
Comment 4 WebKit Commit Bot 2019-02-06 14:55:00 PST 
Comment on attachment 361324 [details]
Patch

Clearing flags on attachment: 361324

Committed r241103: <https://trac.webkit.org/changeset/241103>
Comment 5 WebKit Commit Bot 2019-02-06 14:55:01 PST 
All reviewed patches have been landed.  Closing bug.