Bug 194355 - [ews-app] Fetch builder id to name mapping
Summary: [ews-app] Fetch builder id to name mapping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-06 12:21 PST by Aakash Jain
Modified: 2019-02-13 16:19 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (2.28 KB, patch)
2019-02-06 12:52 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-02-06 12:21:28 PST 
ews-app should fetch builder id to name mapping from Buildbot so that it can display the builer name appropriately on EWS status bubbles.
Comment 1 Aakash Jain 2019-02-06 12:52:53 PST 
Created attachment 361319 [details]
Proposed patch
Comment 2 Lucas Forschler 2019-02-12 15:17:24 PST 
Comment on attachment 361319 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361319&action=review

> Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:63
> +            builder_id = builder['builderid']

do you want to use a .get here as well?
Comment 3 WebKit Commit Bot 2019-02-13 16:16:22 PST 
Comment on attachment 361319 [details]
Proposed patch

Clearing flags on attachment: 361319

Committed r241485: <https://trac.webkit.org/changeset/241485>
Comment 4 WebKit Commit Bot 2019-02-13 16:16:23 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-02-13 16:19:19 PST 
<rdar://problem/48056974>