Bug 194341 – Build failure after r240315

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Pablo Saavedra]

Description:

   Failure happens building WPE with no VIDEO enabled (proably happens as well in other ports):


  -DENABLE_VIDEO=OFF
  -DPORT=WPE 


Diagnosis:

  JSC namespace not added to the Webcore namespace  when video disabled




Build errors:

In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-68aea4ac-14.cpp:6:
/home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp: At global scope:
/home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp:41:91: error: 'SlotVisitor' has not been declared
 bool JSUndoItemOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor, const char** reason)


In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-68aea4ac-14.cpp:6:
/home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp: In member function 'virtual bool WebCore::JSUndoItemOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown>, void*, JSC::SlotVisitor&, const char**)':
/home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+3646d86f28-r0/git/Source/WebCore/bindings/js/JSUndoItemCustom.cpp:46:33: error: 'jsCast' was not declared in this scope
     auto* documentForUndoItem = jsCast<JSUndoItem*>(handle.slot()->asCell())->wrapped().document();
                                 ^~~~~~



Related to: https://bugs.webkit.org/show_bug.cgi?id=193111

[Pablo Saavedra]

Created attachment 361292 [details]
patch

[WebKit Commit Bot]

Comment on attachment 361292 [details]
patch

Clearing flags on attachment: 361292

Committed r241017: <https://trac.webkit.org/changeset/241017>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47849690>