Bug 194331 - [JSC] NativeExecutable should be smaller
Summary: [JSC] NativeExecutable should be smaller
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-06 00:50 PST by Yusuke Suzuki
Modified: 2019-02-06 11:50 PST (History)
3 users (show)

See Also:

Attachments
Patch (46.16 KB, patch)
2019-02-06 01:47 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-02-06 00:50:36 PST 
I think it can be <= 64. (Now, it takes 88).
Comment 1 Yusuke Suzuki 2019-02-06 01:47:26 PST 
Created attachment 361283 [details]
Patch
Comment 2 Yusuke Suzuki 2019-02-06 03:20:06 PST 
Comment on attachment 361283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361283&action=review

> Source/JavaScriptCore/ChangeLog:16
> +           they are not touched from JIT, we can remove them from ExecutableBase and move them to ScriptExecutable.

Actually, these fields are meaningless even in ScriptExecutable. It is used as a flag. So I would like to shrink FunctionExecutable more in a separate patch.
Comment 3 Michael Saboff 2019-02-06 11:22:46 PST 
Comment on attachment 361283 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2019-02-06 11:24:28 PST 
Comment on attachment 361283 [details]
Patch

Thanks!
Comment 5 WebKit Commit Bot 2019-02-06 11:49:09 PST 
Comment on attachment 361283 [details]
Patch

Clearing flags on attachment: 361283

Committed r241037: <https://trac.webkit.org/changeset/241037>
Comment 6 WebKit Commit Bot 2019-02-06 11:49:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-02-06 11:50:31 PST 
<rdar://problem/47858258>