These methods have been added to the ES spec. According to the spec pull request (https://github.com/tc39/ecma262/pull/1309) and to conform to the other JS engines, we should add these properties to @@unscopables. The text below the `Array.prototype[@@unscopables]` section in the ES spec makes it clear that the intention is to *prevent* issues.
Created attachment 372770 [details] Patch Properties order is according to spec.
Comment on attachment 372770 [details] Patch Attachment 372770 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12563750 New failing tests: js/array-unscopables-properties.html
Created attachment 372773 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 372770 [details] Patch Attachment 372770 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12563760 New failing tests: js/array-unscopables-properties.html
Created attachment 372775 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 372770 [details] Patch Attachment 372770 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12563793 New failing tests: js/array-unscopables-properties.html
Created attachment 372780 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 372770 [details] Patch Attachment 372770 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12563904 New failing tests: js/array-unscopables-properties.html
Created attachment 372781 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 372770 [details] Patch Attachment 372770 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12563813 New failing tests: js/array-unscopables-properties.html
Created attachment 372784 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Comment on attachment 372770 [details] Patch Attachment 372770 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12563885 New failing tests: stress/unscopables.js.ftl-no-cjit-no-inline-validate jsc-layout-tests.yaml/js/script-tests/array-unscopables-properties.js.layout-no-ftl stress/unscopables.js.no-ftl stress/unscopables.js.no-cjit-validate-phases stress/unscopables.js.dfg-maximal-flush-validate-no-cjit stress/unscopables.js.dfg-eager-no-cjit-validate stress/unscopables.js.default stress/unscopables.js.ftl-eager-no-cjit-b3o1 stress/unscopables.js.dfg-eager stress/unscopables.js.bytecode-cache stress/unscopables.js.ftl-no-cjit-validate-sampling-profiler jsc-layout-tests.yaml/js/script-tests/array-unscopables-properties.js.layout jsc-layout-tests.yaml/js/script-tests/array-unscopables-properties.js.layout-ftl-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/array-unscopables-properties.js.layout-no-cjit stress/unscopables.js.no-llint stress/unscopables.js.ftl-eager stress/unscopables.js.ftl-no-cjit-no-put-stack-validate stress/unscopables.js.ftl-no-cjit-b3o0 stress/unscopables.js.mini-mode jsc-layout-tests.yaml/js/script-tests/array-unscopables-properties.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/array-unscopables-properties.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/array-unscopables-properties.js.layout-ftl-no-cjit stress/unscopables.js.ftl-eager-no-cjit stress/unscopables.js.no-cjit-collect-continuously stress/unscopables.js.ftl-no-cjit-small-pool apiTests
Comment on attachment 372770 [details] Patch Attachment 372770 [details] did not pass jsc-armv7-ews (jsc-only): Output: https://webkit-queues.webkit.org/results/12563910 New failing tests: jsc-layout-tests.yaml/js/script-tests/array-unscopables-properties.js.layout-no-cjit stress/unscopables.js.mini-mode jsc-layout-tests.yaml/js/script-tests/array-unscopables-properties.js.layout-dfg-eager-no-cjit stress/unscopables.js.dfg-eager jsc-layout-tests.yaml/js/script-tests/array-unscopables-properties.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/array-unscopables-properties.js.layout stress/unscopables.js.no-llint stress/unscopables.js.no-cjit-validate-phases stress/unscopables.js.dfg-eager-no-cjit-validate stress/unscopables.js.dfg-maximal-flush-validate-no-cjit stress/unscopables.js.default stress/unscopables.js.no-cjit-collect-continuously apiTests
Created attachment 372793 [details] Patch Adjust test.
Created attachment 372795 [details] Patch Fix another test.
Comment on attachment 372795 [details] Patch r=me.
Comment on attachment 372795 [details] Patch Clearing flags on attachment: 372795 Committed r246765: <https://trac.webkit.org/changeset/246765>
All reviewed patches have been landed. Closing bug.
<rdar://problem/52074439>