Stop using setDefersLoading from WebCore
Created attachment 361243 [details] Patch
Created attachment 361246 [details] Patch
Comment on attachment 361246 [details] Patch Attachment 361246 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11046486 Number of test failures exceeded the failure limit.
Created attachment 361258 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 361246 [details] Patch Attachment 361246 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11047079 Number of test failures exceeded the failure limit.
Created attachment 361263 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 361246 [details] Patch Attachment 361246 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11048173 Number of test failures exceeded the failure limit.
Created attachment 361272 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 361246 [details] Patch Attachment 361246 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11049721 Number of test failures exceeded the failure limit.
Created attachment 361280 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 361246 [details] Patch Looks like this patch needs some more work.
Created attachment 361448 [details] Patch
Comment on attachment 361448 [details] Patch Attachment 361448 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11072340 New failing tests: http/tests/inspector/network/resource-initiatorNode.html
Created attachment 361466 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 361510 [details] Patch
Note: this does affect the gstreamer loader, too. Not completely sure what you want to do about the full/resume case.
http://trac.webkit.org/r241273
<rdar://problem/47970932>
Re-opened since this is blocked by bug 194579
Test is causing an Assertion failure crash with test http/tests/inspector/network/resource-initiatorNode.html on High Sierra Debug Flakiness Dashboard: http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fresource-initiatorNode.html Reproduced with: run-webkit-tests d241273 http/tests/inspector/network/resource-initiatorNode.html --iterations 500 -f --debug --exit-after-n-failures=1 --no-retry-failures stderr: ASSERTION FAILED: Completion handler should always be called !m_function /Volumes/Data/slave/highsierra-debug/build/WebKitBuild/Debug/usr/local/include/wtf/CompletionHandler.h(51) : WTF::CompletionHandler<void (WebCore::ShouldContinue)>::~CompletionHandler() 1 0x4f1d6ecd9 WTFCrash 2 0x4e2c5e4c7 WTF::CompletionHandler<void (WebCore::ShouldContinue)>::~CompletionHandler() 3 0x4e2c50595 WTF::CompletionHandler<void (WebCore::ShouldContinue)>::~CompletionHandler()
Comment on attachment 361510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361510&action=review > Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:639 > - [self.session addDelegateOperation:[strongSelf, strongResponse] { > + [self.session addDelegateOperation:[strongSelf, strongResponse, completionHandler = WTFMove(completionHandler)] () mutable { I recommitted to http://trac.webkit.org/r241444 by adding a null check for self.session here.