Bug 194315 - Stop using setDefersLoading from WebCore
Summary: Stop using setDefersLoading from WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on: 194579
Blocks:
  Show dependency treegraph
 
Reported: 2019-02-05 16:34 PST by Alex Christensen
Modified: 2019-02-13 11:01 PST (History)
8 users (show)

See Also:


Attachments
Patch (11.29 KB, patch)
2019-02-05 16:35 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (11.35 KB, patch)
2019-02-05 16:44 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-highsierra (2.28 MB, application/zip)
2019-02-05 17:33 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (1.20 MB, application/zip)
2019-02-05 18:36 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews115 for mac-highsierra (1.94 MB, application/zip)
2019-02-05 20:42 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.52 MB, application/zip)
2019-02-06 00:16 PST, EWS Watchlist
no flags Details
Patch (14.73 KB, patch)
2019-02-07 14:38 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-highsierra (2.32 MB, application/zip)
2019-02-07 16:20 PST, EWS Watchlist
no flags Details
Patch (14.78 KB, patch)
2019-02-08 09:27 PST, Alex Christensen
jer.noble: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-02-05 16:34:33 PST
Stop using setDefersLoading from WebCore
Comment 1 Alex Christensen 2019-02-05 16:35:29 PST
Created attachment 361243 [details]
Patch
Comment 2 Alex Christensen 2019-02-05 16:44:38 PST
Created attachment 361246 [details]
Patch
Comment 3 EWS Watchlist 2019-02-05 17:33:48 PST
Comment on attachment 361246 [details]
Patch

Attachment 361246 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11046486

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2019-02-05 17:33:50 PST
Created attachment 361258 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 5 EWS Watchlist 2019-02-05 18:36:51 PST
Comment on attachment 361246 [details]
Patch

Attachment 361246 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11047079

Number of test failures exceeded the failure limit.
Comment 6 EWS Watchlist 2019-02-05 18:36:52 PST
Created attachment 361263 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 7 EWS Watchlist 2019-02-05 20:42:39 PST
Comment on attachment 361246 [details]
Patch

Attachment 361246 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11048173

Number of test failures exceeded the failure limit.
Comment 8 EWS Watchlist 2019-02-05 20:42:41 PST
Created attachment 361272 [details]
Archive of layout-test-results from ews115 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 9 EWS Watchlist 2019-02-06 00:16:11 PST
Comment on attachment 361246 [details]
Patch

Attachment 361246 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11049721

Number of test failures exceeded the failure limit.
Comment 10 EWS Watchlist 2019-02-06 00:16:13 PST
Created attachment 361280 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 11 Ryosuke Niwa 2019-02-06 22:13:29 PST
Comment on attachment 361246 [details]
Patch

Looks like this patch needs some more work.
Comment 12 Alex Christensen 2019-02-07 14:38:28 PST
Created attachment 361448 [details]
Patch
Comment 13 EWS Watchlist 2019-02-07 16:20:21 PST
Comment on attachment 361448 [details]
Patch

Attachment 361448 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11072340

New failing tests:
http/tests/inspector/network/resource-initiatorNode.html
Comment 14 EWS Watchlist 2019-02-07 16:20:23 PST
Created attachment 361466 [details]
Archive of layout-test-results from ews115 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 15 Alex Christensen 2019-02-08 09:27:42 PST
Created attachment 361510 [details]
Patch
Comment 16 Alex Christensen 2019-02-11 11:01:41 PST
Note: this does affect the gstreamer loader, too.  Not completely sure what you want to do about the full/resume case.
Comment 17 Alex Christensen 2019-02-11 11:03:01 PST
http://trac.webkit.org/r241273
Comment 18 Radar WebKit Bug Importer 2019-02-11 11:03:44 PST
<rdar://problem/47970932>
Comment 19 WebKit Commit Bot 2019-02-12 18:10:44 PST
Re-opened since this is blocked by bug 194579
Comment 20 Shawn Roberts 2019-02-12 18:14:35 PST
Test is causing an Assertion failure crash with test http/tests/inspector/network/resource-initiatorNode.html on High Sierra Debug

Flakiness Dashboard:

http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fresource-initiatorNode.html

Reproduced with:

run-webkit-tests d241273 http/tests/inspector/network/resource-initiatorNode.html --iterations 500 -f --debug --exit-after-n-failures=1 --no-retry-failures

stderr:

ASSERTION FAILED: Completion handler should always be called
!m_function
/Volumes/Data/slave/highsierra-debug/build/WebKitBuild/Debug/usr/local/include/wtf/CompletionHandler.h(51) : WTF::CompletionHandler<void (WebCore::ShouldContinue)>::~CompletionHandler()
1   0x4f1d6ecd9 WTFCrash
2   0x4e2c5e4c7 WTF::CompletionHandler<void (WebCore::ShouldContinue)>::~CompletionHandler()
3   0x4e2c50595 WTF::CompletionHandler<void (WebCore::ShouldContinue)>::~CompletionHandler()
Comment 21 Alex Christensen 2019-02-13 11:01:23 PST
Comment on attachment 361510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361510&action=review

> Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:639
> -    [self.session addDelegateOperation:[strongSelf, strongResponse] {
> +    [self.session addDelegateOperation:[strongSelf, strongResponse, completionHandler = WTFMove(completionHandler)] () mutable {

I recommitted to http://trac.webkit.org/r241444 by adding a null check for self.session here.