Bug 194313 - fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
Summary: fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-05 15:47 PST by Jonathan Bedard
Modified: 2019-02-11 11:32 PST (History)
8 users (show)

See Also:


Attachments
Patch (17.55 KB, patch)
2019-02-11 09:09 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (18.35 KB, patch)
2019-02-11 09:50 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-02-05 15:47:34 PST
This prevents us from running fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html. On iPad, calendarTypeString will not be defined.
Comment 1 Wenson Hsieh 2019-02-11 09:09:53 PST
Created attachment 361684 [details]
Patch
Comment 2 Jonathan Bedard 2019-02-11 09:46:40 PST
Don't we need to un-skip this test on iPad in this patch too?
Comment 3 Wenson Hsieh 2019-02-11 09:49:29 PST
(In reply to Jonathan Bedard from comment #2)
> Don't we need to un-skip this test on iPad in this patch too?

Good catch :)
Comment 4 Wenson Hsieh 2019-02-11 09:50:04 PST
Created attachment 361688 [details]
Patch
Comment 5 Wenson Hsieh 2019-02-11 11:01:56 PST
Comment on attachment 361688 [details]
Patch

Thanks for the review!
Comment 6 WebKit Commit Bot 2019-02-11 11:30:11 PST
Comment on attachment 361688 [details]
Patch

Clearing flags on attachment: 361688

Committed r241275: <https://trac.webkit.org/changeset/241275>
Comment 7 WebKit Commit Bot 2019-02-11 11:30:12 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-02-11 11:32:01 PST
<rdar://problem/47972170>