Bug 194312 - Make sure to clear sources from UserMediaCaptureManagerProxy and UserMediaCaptureManager when no longer needed
Summary: Make sure to clear sources from UserMediaCaptureManagerProxy and UserMediaCap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-05 15:34 PST by youenn fablet
Modified: 2019-02-07 11:20 PST (History)
5 users (show)

See Also:

Attachments
Patch (12.10 KB, patch)
2019-02-05 15:42 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (60.46 KB, patch)
2019-02-06 16:57 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (12.17 KB, patch)
2019-02-07 10:37 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-02-05 15:34:25 PST 
Make to clear sources from UserMediaCaptureManagerProxy and UserMediaCaptureManager when no longer needed
Comment 1 youenn fablet 2019-02-05 15:42:54 PST 
Created attachment 361232 [details]
Patch
Comment 2 EWS Watchlist 2019-02-05 15:46:47 PST 
Attachment 361232 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:214:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Radar WebKit Bug Importer 2019-02-05 16:20:39 PST 
<rdar://problem/47836112>
Comment 4 youenn fablet 2019-02-06 16:57:15 PST 
Created attachment 361347 [details]
Patch
Comment 5 EWS Watchlist 2019-02-06 17:00:05 PST 
Attachment 361347 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:214:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 youenn fablet 2019-02-07 10:37:44 PST 
Created attachment 361412 [details]
Patch for landing
Comment 7 EWS Watchlist 2019-02-07 10:40:18 PST 
Attachment 361412 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:214:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2019-02-07 11:20:21 PST 
Comment on attachment 361412 [details]
Patch for landing

Clearing flags on attachment: 361412

Committed r241132: <https://trac.webkit.org/changeset/241132>
Comment 9 WebKit Commit Bot 2019-02-07 11:20:22 PST 
All reviewed patches have been landed.  Closing bug.