Bug 194311 - [Payment Request] It should be possible to require a phonetic name for shipping contacts
Summary: [Payment Request] It should be possible to require a phonetic name for shippi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-05 15:18 PST by Andy Estes
Modified: 2019-02-06 15:18 PST (History)
14 users (show)

See Also:

Attachments
Patch (56.56 KB, patch)
2019-02-05 15:29 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (55.58 KB, patch)
2019-02-05 15:34 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (55.58 KB, patch)
2019-02-06 09:39 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (55.55 KB, patch)
2019-02-06 14:39 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-02-05 15:18:36 PST 
[Payment Request] It should be possible to require a phonetic name for shipping contacts
Comment 1 Andy Estes 2019-02-05 15:18:54 PST 
rdar://46733045
Comment 2 Andy Estes 2019-02-05 15:29:19 PST Comment hidden (obsolete)
Comment 3 Andy Estes 2019-02-05 15:34:28 PST Comment hidden (obsolete)
Comment 4 Andy Estes 2019-02-05 16:13:53 PST 
Comment on attachment 361229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361229&action=review

> Source/WebCore/DerivedSources.make:1053
> +	$(WebCore)/testing/MockPaymentContactFields.idl \

Oops, tab
Comment 5 Andy Estes 2019-02-06 09:39:36 PST Comment hidden (obsolete)
Comment 6 Andy Estes 2019-02-06 10:46:53 PST 
Comment on attachment 361301 [details]
Patch

Alex reviewed in person. He asked that I added some more test cases, which I'll do.
Comment 7 Andy Estes 2019-02-06 14:39:40 PST 
Created attachment 361331 [details]
Patch
Comment 8 WebKit Commit Bot 2019-02-06 15:18:13 PST 
Comment on attachment 361331 [details]
Patch

Clearing flags on attachment: 361331

Committed r241105: <https://trac.webkit.org/changeset/241105>
Comment 9 WebKit Commit Bot 2019-02-06 15:18:15 PST 
All reviewed patches have been landed.  Closing bug.