Bug 194303 - Disable audio ducking at Audio Unit setup time
Summary: Disable audio ducking at Audio Unit setup time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-05 14:39 PST by youenn fablet
Modified: 2019-02-06 08:58 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.65 KB, patch)
2019-02-05 15:14 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.66 MB, application/zip)
2019-02-05 17:17 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-02-05 14:39:35 PST
UIProcess should not keep an audio unit when not capturing
Comment 1 youenn fablet 2019-02-05 15:14:29 PST
Created attachment 361226 [details]
Patch
Comment 2 youenn fablet 2019-02-05 15:27:40 PST
<rdar://problem/45354090>
Comment 3 Build Bot 2019-02-05 17:17:43 PST
Comment on attachment 361226 [details]
Patch

Attachment 361226 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11045354

New failing tests:
editing/pasteboard/smart-paste-007.html
editing/pasteboard/smart-paste-008.html
Comment 4 Build Bot 2019-02-05 17:17:44 PST
Created attachment 361251 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 5 youenn fablet 2019-02-06 08:33:31 PST
Comment on attachment 361226 [details]
Patch

EWS errors unrelated
Comment 6 WebKit Commit Bot 2019-02-06 08:58:51 PST
Comment on attachment 361226 [details]
Patch

Clearing flags on attachment: 361226

Committed r241021: <https://trac.webkit.org/changeset/241021>
Comment 7 WebKit Commit Bot 2019-02-06 08:58:53 PST
All reviewed patches have been landed.  Closing bug.