In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU. This can cause build failures if libidn is detected but libunistring is not available. Make sure that ICU is used for runtime and builtin PSL data.
Created attachment 361193 [details] Patch
Comment on attachment 361193 [details] Patch Clearing flags on attachment: 361193 Committed r240987: <https://trac.webkit.org/changeset/240987>
All reviewed patches have been landed. Closing bug.
Comment on attachment 361193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361193&action=review > Tools/gtk/jhbuild.modules:234 > <branch module="rockdaboot/libpsl/releases/download/libpsl-${version}/libpsl-${version}.tar.gz" We should add icu as a dependency here like we do in WPE to ensure it's built before. Could you do it in a follow up patch, please? rs=me
Reopening to attach new patch.
Created attachment 361290 [details] Patch
Comment on attachment 361290 [details] Patch Clearing flags on attachment: 361290 Committed r241016: <https://trac.webkit.org/changeset/241016>