Bug 194282 – Web Inspector: Fix modify-css-property-race.html test failures

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Introduced by Bug 192739: Web Inspector: Styles: fix race conditions when editing.

[Nikita Vasilyev]

Created attachment 361166 [details]
Patch

Run tests on EWS.

[Nikita Vasilyev]

Created attachment 361167 [details]
Patch

Don't review. This is for EWS.

[Nikita Vasilyev]

Created attachment 361168 [details]
Patch

[Nikita Vasilyev]

Created attachment 361169 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 361169 [details]
Patch

This patch hasn't changed anything yet, right?

[Nikita Vasilyev]

(In reply to Joseph Pecoraro from comment #5)
> Comment on attachment 361169 [details]
> Patch
> 
> This patch hasn't changed anything yet, right?

It did!

expectGreaterThan(43, 42) logs "PASS: expectGreaterThan(43, 42)".

Imagine, the actual value would be 44 or 45. It would still pass the assertion, but it would log "PASS: expectGreaterThan(45, 42)", causing the test to fail.

[Matt Baker]

Comment on attachment 361169 [details]
Patch

rs=me

[Matt Baker]

Let's put a comment in the change log that this fixing a test failure introduced in https://trac.webkit.org/changeset/240946.

[Nikita Vasilyev]

Created attachment 361208 [details]
Patch

[Nikita Vasilyev]

Created attachment 361209 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 361209 [details]
Patch

Clearing flags on attachment: 361209

Committed r240989: <https://trac.webkit.org/changeset/240989>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47827420>

[Shawn Roberts]

test is still a flaky failure on Mac WK2, WK1 Debug

Reproduced with:

run-webkit-tests t240999 inspector/css/modify-css-property-race.html --iterations 500 -f --debug -1

run-webkit-tests t240999 inspector/css/modify-css-property-race.html --iterations 500 -f --debug

run-webkit-tests t240999 inspector/css/modify-css-property-race.html --iterations 500 -f

Flakiness dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcss%2Fmodify-css-property-race.html

Diff: 

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/inspector/css/modify-css-property-race-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/inspector/css/modify-css-property-race-actual.txt
@@ -3,9 +3,15 @@
 
 == Running test suite: ModifyCSSProperty
 -- Running test case: ModifyCSSPropertyRace.ChangeInlineStyle
-PASS: expectGreaterThan(43, 42)
-PASS: expectGreaterThan(43, 42)
-PASS: Value updated to "10px".
+FAIL: expectGreaterThan(42, 42)
+    Expected: greater than 42
+    Actual: 42
+FAIL: expectGreaterThan(42, 42)
+    Expected: greater than 42
+    Actual: 42
+FAIL: Value updated to "10px".
+    Expected: "10px"
+    Actual: "44px"
 PASS: CSSStyleDeclaration text should update.
-PASS: expectGreaterThanOrEqual(10, 10)
+PASS: expectGreaterThanOrEqual(44, 10)

[Nikita Vasilyev]

Thanks, I'm working on the fix in https://bugs.webkit.org/show_bug.cgi?id=194318.

[Nikita Vasilyev]

modify-css-property-race.html shouldn't be flaky after https://trac.webkit.org/changeset/241011