Bug 194277 – [JSC] PrivateName to PublicName hash table is wasteful

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] PrivateName to PublicName hash table is wasteful

[Yusuke Suzuki]

Created attachment 361158 [details]
Patch

[EWS Watchlist]

Comment on attachment 361158 [details]
Patch

Attachment 361158 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/11036414

New failing tests:
stress/arity-check-ftl-throw-more-args.js.bytecode-cache
stress/super-property-access-object-literal-to-this.js.bytecode-cache
stress/arguments-non-configurable.js.bytecode-cache
stress/internal-function-construct.js.bytecode-cache
microbenchmarks/large-map-iteration.js.bytecode-cache
stress/regress-185896.js.bytecode-cache
stress/get-by-val-with-symbol-constructor.js.bytecode-cache
stress/spread-escapes-but-create-rest-does-not.js.bytecode-cache
stress/class-syntax-tdz-in-eval.js.bytecode-cache
stress/array-slice-intrinsic.js.bytecode-cache
stress/get-by-val-with-string-constructor.js.bytecode-cache
stress/es6-for-of-loop-exception.js.bytecode-cache
stress/phantom-regexp-string-match.js.bytecode-cache
stress/regexp-compile-oom.js.bytecode-cache
stress/rest-parameter-basics.js.bytecode-cache
stress/typed-array-array-modes-profile.js.bytecode-cache
stress/async-iteration-syntax.js.bytecode-cache
stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js.bytecode-cache
stress/proxy-revoke.js.bytecode-cache
stress/symbol-tostringtag.js.bytecode-cache
stress/proxy-basic.js.bytecode-cache
stress/model-effects-properly-of-spread-over-phantom-create-rest.js.bytecode-cache
stress/raise-error-in-iterator-close.js.bytecode-cache
microbenchmarks/data-view-accesses-2.js.bytecode-cache
microbenchmarks/for-of-iterate-array-values.js.bytecode-cache
stress/dataview-jit-neuter.js.bytecode-cache
stress/async-await-mozilla.js.bytecode-cache
stress/object-keys-perform-to-object.js.bytecode-cache
stress/arrowfunction-lexical-bind-supercall-4.js.bytecode-cache
stress/typedarray-sort.js.bytecode-cache
stress/symbol-toprimitive.js.bytecode-cache
stress/static-getter-names.js.bytecode-cache
stress/arguments-define-property.js.bytecode-cache
stress/arrowfunction-tdz-4.js.bytecode-cache
stress/map-set-does-not-clobber-weak-map-get.js.bytecode-cache
stress/phantom-new-array-buffer-forward-varargs.js.bytecode-cache
stress/regress-172346.js.bytecode-cache
stress/instanceof.js.bytecode-cache
stress/to-number-throws-correct-exception.js.bytecode-cache
stress/primitive-poly-proto.js.bytecode-cache
stress/value-add-on-double-array-with-holes.js.bytecode-cache
stress/weakmap-set-cse.js.bytecode-cache
stress/dataview-jit-bounds-checks.js.bytecode-cache
stress/arrowfunction-lexical-bind-newtarget.js.bytecode-cache
stress/proxy-all-the-parameters.js.bytecode-cache
stress/typedarray-find.js.bytecode-cache
stress/to-object-intrinsic-boolean-edge.js.bytecode-cache
microbenchmarks/sorting-benchmark.js.bytecode-cache
stress/template-literal.js.bytecode-cache
stress/proxy-instanceof.js.bytecode-cache
stress/for-in-of-const.js.bytecode-cache
stress/put-direct-index-broken-2.js.bytecode-cache
stress/typedarray-configure-index.js.bytecode-cache
stress/rest-parameter-is-destructuring.js.bytecode-cache
stress/compare-number-and-other.js.bytecode-cache
stress/having-a-bad-time-with-derived-arrays.js.bytecode-cache
stress/array-flatmap.js.bytecode-cache
stress/materialize-regexp-cyclic-regexp.js.bytecode-cache
stress/arrowfunction-lexical-bind-supercall-1.js.bytecode-cache
stress/map-untyped-normalize-cse.js.bytecode-cache
stress/rest-elements.js.bytecode-cache
stress/arity-check-ftl-throw.js.bytecode-cache
stress/has-own-property-name-cache-symbols-and-strings.js.bytecode-cache
stress/sub-order-evaluation.js.bytecode-cache
stress/arrowfunction-others.js.bytecode-cache
stress/regexp-match.js.bytecode-cache
stress/phantom-spread-osr-exit.js.bytecode-cache
stress/array-slice-jettison-on-constructor-change.js.bytecode-cache
stress/set-untyped-normalize.js.bytecode-cache
stress/class-subclassing-misc.js.bytecode-cache
stress/object-constructor-global.js.bytecode-cache
stress/object-constructor-number-edge.js.bytecode-cache
stress/do-eval-virtual-call-correctly.js.bytecode-cache
stress/always-enter-dictionary-indexing-mode-with-getter.js.bytecode-cache
microbenchmarks/emscripten-cube2hash.js.bytecode-cache
stress/spread-escapes-but-new-array-buffer-does-not-double.js.bytecode-cache
stress/async-iteration-yield-star-interface.js.bytecode-cache
stress/generic-arguments-correct-delete-behavior.js.bytecode-cache
stress/trailing-comma-in-patterns.js.bytecode-cache
stress/instanceof-custom-hasinstancesymbol.js.bytecode-cache
stress/yield-star-throw-continue.js.bytecode-cache
stress/instance-of-on-poly-proto-opc-should-not-crash.js.bytecode-cache
stress/phantom-new-array-buffer-osr-exit.js.bytecode-cache
stress/logical-not.js.bytecode-cache
stress/object-is-extensible-accept-non-object.js.bytecode-cache
stress/inferred-names.js.bytecode-cache
stress/object-constructor-symbol-edge.js.bytecode-cache
stress/string-compare.js.bytecode-cache
stress/poly-proto-prototype-map-having-a-bad-time.js.bytecode-cache
microbenchmarks/for-of-iterate-array-entries.js.bytecode-cache
stress/instanceof-late-constant-folding.js.bytecode-cache
stress/new-target.js.bytecode-cache
stress/object-seal-accept-non-object.js.bytecode-cache
stress/string-from-code-point.js.bytecode-cache
microbenchmarks/for-of-iterate-array-keys.js.bytecode-cache
stress/set-untyped-normalize-cse.js.bytecode-cache
stress/super-method-calls-check-tdz.js.bytecode-cache
stress/has-own-property-name-cache-symbol-keys.js.bytecode-cache
stress/modify-set-during-iteration.js.bytecode-cache
microbenchmarks/generator-sunspider-access-nsieve.js.bytecode-cache
stress/phantom-new-array-with-spread-osr-exit.js.bytecode-cache
stress/typedarray-set.js.bytecode-cache
stress/dont-constant-fold-check-type-info-on-bound-function.js.bytecode-cache
stress/native-error-properties.js.bytecode-cache
stress/instanceof-proxy-check-structure.js.bytecode-cache
stress/new-target-syntax-errors.js.bytecode-cache
stress/forward-varargs-double-new-array-buffer.js.bytecode-cache
stress/fold-load-varargs-arity-check-fail.js.bytecode-cache
stress/async-arrow-functions-lexical-arguments-binding.js.bytecode-cache
stress/spread-escapes-but-new-array-buffer-does-not.js.bytecode-cache
stress/async-generator-assertion.js.bytecode-cache
stress/arrowfunction-lexical-bind-supercall-3.js.bytecode-cache
stress/yield-out-of-generator.js.bytecode-cache
stress/has-own-property-cache-basics.js.bytecode-cache
stress/tail-call-recognize.js.bytecode-cache
stress/generator-prototype-copy.js.bytecode-cache
stress/dataview-jit-unaligned-accesses.js.bytecode-cache
stress/class-syntax-tdz-osr-entry-in-loop.js.bytecode-cache
stress/map-untyped-normalize.js.bytecode-cache
stress/super-get-by-id.js.bytecode-cache
stress/class-syntax-super-in-eval.js.bytecode-cache
stress/typedarray-view-string-properties-neutered.js.bytecode-cache
stress/ignore-promise-species.js.bytecode-cache
microbenchmarks/instanceof-dynamic.js.bytecode-cache
stress/const-loop-semantics.js.bytecode-cache
stress/object-get-prototype-of-perform-to-object.js.bytecode-cache
stress/sampling-profiler-bound-function-name.js.bytecode-cache
stress/variable-under-tdz-eval-tricky.js.bytecode-cache
stress/array-symbol-species-lazy-watchpoints.js.bytecode-cache
stress/object-get-own-property-symbols-perform-to-object.js.bytecode-cache
stress/sampling-profiler-deep-stack.js.bytecode-cache
stress/math-pow-stable-results.js.bytecode-cache
stress/typedarray-indexOf.js.bytecode-cache
stress/weakset-add-cse.js.bytecode-cache
stress/block-scope-redeclarations.js.bytecode-cache
stress/async-await-basic.js.bytecode-cache
microbenchmarks/data-view-accesses.js.bytecode-cache
stress/lexical-scoping-for-loop.js.bytecode-cache
microbenchmarks/try-catch-word-count.js.bytecode-cache
stress/jit-gracefully-handle-double-constants-in-math-operators.js.bytecode-cache
stress/typedarray-every.js.bytecode-cache
microbenchmarks/sinkable-new-object-with-builtin-constructor.js.bytecode-cache
stress/new-array-with-spread-with-normal-spread-and-phantom-spread.js.bytecode-cache
stress/tagged-templates-raw-strings.js.bytecode-cache
stress/array-from-with-iterable.js.bytecode-cache
stress/spread-forward-varargs-stack-overflow.js.bytecode-cache
stress/double-to-int32-NaN.js.bytecode-cache
microbenchmarks/poly-proto-access.js.bytecode-cache
stress/arguments-iterator.js.bytecode-cache
stress/iterator-return-beyond-multiple-iteration-scopes.js.bytecode-cache
stress/sampling-profiler-display-name.js.bytecode-cache
stress/instanceof-hit-one-object-then-another.js.bytecode-cache
stress/destructuring-rest-element.js.bytecode-cache
microbenchmarks/instanceof-always-hit-one.js.bytecode-cache
stress/arrowfunction-tdz-3.js.bytecode-cache
stress/es6-default-parameters.js.bytecode-cache
stress/global-lexical-redeclare-variable.js.bytecode-cache
stress/destructuring-assignment-syntax.js.bytecode-cache
stress/weak-map-constructor.js.bytecode-cache
stress/typedarray-forEach.js.bytecode-cache
stress/typedarray-reduceRight.js.bytecode-cache
stress/iterator-names.js.bytecode-cache
stress/instanceof-prototype-change-to-null.js.bytecode-cache
stress/generator-frame-empty.js.bytecode-cache
stress/object-is-sealed-accept-non-object.js.bytecode-cache
microbenchmarks/to-string-on-cow-array.js.bytecode-cache
stress/number-prototype-to-string-wrong-values.js.bytecode-cache
stress/symbol-instanceof.js.bytecode-cache
microbenchmarks/sparse-set.js.bytecode-cache
stress/poly-proto-set-prototype.js.bytecode-cache
stress/iterators-shape.js.bytecode-cache
microbenchmarks/is-symbol-mixed.js.bytecode-cache
stress/to-object-intrinsic.js.bytecode-cache
stress/async-iteration-yield-star.js.bytecode-cache
stress/map-constructor.js.bytecode-cache
stress/class-syntax-definition-semantics.js.bytecode-cache
stress/class-derived-from-null.js.bytecode-cache
stress/catch-clause-should-be-under-tdz1.js.bytecode-cache
stress/create-this-with-callee-variants.js.bytecode-cache
stress/super-property-access.js.bytecode-cache
stress/object-entries.js.bytecode-cache
microbenchmarks/set-for-of.js.bytecode-cache
stress/catch-variables-under-tdz.js.bytecode-cache
stress/typedarray-filter.js.bytecode-cache
stress/materialize-regexp-cyclic.js.bytecode-cache
microbenchmarks/constant-fold-check-type-info-flags.js.bytecode-cache
stress/array-from-with-accessors.js.bytecode-cache
stress/instanceof-proxy.js.bytecode-cache
stress/array-species-functions.js.bytecode-cache
stress/math-unary-no-arg.js.bytecode-cache
stress/regexp-search.js.bytecode-cache
stress/create-subclass-structure-might-throw.js.bytecode-cache
stress/object-get-own-property-descriptor-perform-to-object.js.bytecode-cache
stress/function-constructor-semantics.js.bytecode-cache
stress/async-iteration-evaluation.js.bytecode-cache
stress/spread-calling.js.bytecode-cache
microbenchmarks/is-array-for-mixed-case.js.bytecode-cache
stress/materialized-regexp-has-correct-last-index-set-by-match-at-osr-exit.js.bytecode-cache
stress/class-subclassing-function.js.bytecode-cache
stress/async-await-syntax.js.bytecode-cache
stress/arith-sub-on-double-array-with-holes.js.bytecode-cache
stress/typedarray-reduce.js.bytecode-cache
stress/arith-add-on-double-array-with-holes.js.bytecode-cache
stress/hoist-get-by-offset-with-control-dependent-inferred-type.js.bytecode-cache
stress/typedarray-copyWithin.js.bytecode-cache
stress/array-prototype-splice-making-typed-array.js.bytecode-cache
stress/function-constructor-reading-from-global-lexical-environment.js.bytecode-cache
stress/typedarray-slice.js.bytecode-cache
stress/class-subclassing-typedarray.js.bytecode-cache
stress/symbol-registry.js.bytecode-cache
stress/proxy-stack-overflow-exceptions.js.bytecode-cache
stress/get-by-id-strict-nested-arguments-2.js.bytecode-cache
stress/set-iterators-next.js.bytecode-cache
microbenchmarks/call-spread-apply.js.bytecode-cache
stress/spread-forward-call-varargs-stack-overflow.js.bytecode-cache
stress/class-syntax-tdz-in-loop.js.bytecode-cache
stress/instanceof-proxy-loop.js.bytecode-cache
stress/array-iterators-next-with-call.js.bytecode-cache
stress/arrowfunction-lexical-bind-supercall-2.js.bytecode-cache
microbenchmarks/instanceof-sometimes-hit.js.bytecode-cache
stress/to-object-intrinsic-number-edge.js.bytecode-cache
stress/typedarray-subarray.js.bytecode-cache
stress/array-slice-osr-exit-2.js.bytecode-cache
stress/map-iteration.js.bytecode-cache
stress/spread-non-array.js.bytecode-cache
microbenchmarks/map-has-get-cse-opportunity.js.bytecode-cache
stress/array-from-set-length.js.bytecode-cache
stress/generator-relations.js.bytecode-cache
stress/dataview-typedarray-toindex.js.bytecode-cache
stress/lexical-let-loop-semantics.js.bytecode-cache
stress/map-iterators-next.js.bytecode-cache
stress/poly-proto-op-in-caching.js.bytecode-cache
stress/materialize-regexp.js.bytecode-cache
stress/intl-constructors-with-proxy.js.bytecode-cache
stress/array-copywithin.js.bytecode-cache
stress/array-iterators-next.js.bytecode-cache
microbenchmarks/instanceof-bound.js.bytecode-cache
stress/regress-182419.js.bytecode-cache
stress/instanceof-prototype-change-to-hit.js.bytecode-cache
stress/super-property-access-tdz.js.bytecode-cache
stress/instanceof-not-cell.js.bytecode-cache
stress/phantom-regexp-regexp-exec.js.bytecode-cache
stress/array-species-config-array-constructor.js.bytecode-cache
stress/typedarray-some.js.bytecode-cache
stress/catch-clause-should-be-under-tdz4.js.bytecode-cache
stress/set-add-create-bucket.js.bytecode-cache
stress/typedarray-lastIndexOf.js.bytecode-cache
stress/weakmap-set-change-get.js.bytecode-cache
stress/materialize-regexp-at-osr-exit.js.bytecode-cache
stress/new-array-with-spread-double-new-array-buffer.js.bytecode-cache
stress/number-is-integer-intrinsic.js.bytecode-cache
microbenchmarks/object-is.js.bytecode-cache
stress/typedarray-includes.js.bytecode-cache
stress/typedarray-functions-with-neutered.js.bytecode-cache
stress/arrowfunction-tdz-2.js.bytecode-cache
stress/phantom-spread-forward-varargs.js.bytecode-cache
stress/parameter-scoping.js.bytecode-cache
stress/sampling-profiler-anonymous-function.js.bytecode-cache
stress/set-add-clobber-set-has.js.bytecode-cache
stress/fromCharCode-exception-check.js.bytecode-cache
stress/tagged-templates-template-object.js.bytecode-cache
stress/sampling-profiler-should-not-sample-beyond-stack-bounds.js.bytecode-cache
stress/set-constructor.js.bytecode-cache
stress/direct-arguments-check-array.js.bytecode-cache
stress/for-in-tests.js.bytecode-cache
stress/put-inline-cache-side-effects.js.bytecode-cache
stress/arrowfunction-lexical-bind-superproperty.js.bytecode-cache
stress/object-constructor-boolean-edge.js.bytecode-cache
stress/class-syntax-tdz.js.bytecode-cache
stress/to-object-intrinsic-string-edge.js.bytecode-cache
stress/phantom-new-array-buffer-forward-varargs2.js.bytecode-cache
stress/weakset-add-change-get.js.bytecode-cache
stress/number-prototype-to-string-cast-overflow.js.bytecode-cache
stress/class-subclassing-array.js.bytecode-cache
stress/materialized-regexp-has-correct-last-index-set-by-match.js.bytecode-cache
stress/new-string-object.js.bytecode-cache
stress/in-by-id-match.js.bytecode-cache
stress/proxy-define-own-property.js.bytecode-cache
stress/catch-parameter-destructuring.js.bytecode-cache
stress/async-iteration-async-from-sync.js.bytecode-cache
stress/array-slice-osr-exit.js.bytecode-cache
stress/weakset-cse-add-break.js.bytecode-cache
stress/has-own-property-name-cache-string-keys.js.bytecode-cache
stress/object-from-entries.js.bytecode-cache
stress/async-iteration-for-await-of.js.bytecode-cache
stress/instanceof-dynamic-proxy.js.bytecode-cache
stress/weak-set-constructor.js.bytecode-cache
stress/set-add-cse.js.bytecode-cache
stress/custom-iterators.js.bytecode-cache
stress/sampling-profiler-internal-function-name.js.bytecode-cache
stress/logical-not-masquerades-as-undefined.js.bytecode-cache
stress/typedarray-access-monomorphic-neutered.js.bytecode-cache
stress/sloppy-mode-function-hoisting.js.bytecode-cache
stress/arith-modulo-twice.js.bytecode-cache
stress/object-freeze-accept-non-object.js.bytecode-cache
microbenchmarks/deltablue-for-of.js.bytecode-cache
stress/object-is-frozen-accept-non-object.js.bytecode-cache
stress/v8-parameter-scoping.js.bytecode-cache
stress/to-object-intrinsic-symbol-edge.js.bytecode-cache
stress/pow-expects-update-expression-on-lhs.js.bytecode-cache
stress/map-set-change-get.js.bytecode-cache
stress/map-set-cse.js.bytecode-cache
stress/in-by-id-constant.js.bytecode-cache
stress/variable-named-eval-under-tdz.js.bytecode-cache
stress/prototype-is-not-js-object.js.bytecode-cache
stress/with.js.bytecode-cache
stress/typedarray-access-neutered.js.bytecode-cache
microbenchmarks/map-for-of.js.bytecode-cache
stress/generator-function-constructor.js.bytecode-cache
stress/async-arrow-functions-lexical-binding-in-class.js.bytecode-cache
stress/arrowfunction-tdz-1.js.bytecode-cache
stress/proxy-get-prototype-of.js.bytecode-cache
microbenchmarks/instanceof-always-hit-two.js.bytecode-cache
stress/object-get-own-property-names-perform-to-object.js.bytecode-cache
stress/typedarray-map.js.bytecode-cache
stress/spread-in-tail.js.bytecode-cache
stress/template-literal-syntax.js.bytecode-cache
stress/instanceof-dynamic-proxy-check-structure.js.bytecode-cache
stress/constructor-with-return.js.bytecode-cache
stress/instanceof-prototype-change-watchpointable.js.bytecode-cache
stress/materialize-regexp-cyclic-regexp-at-osr-exit.js.bytecode-cache
stress/object-constructor-string-edge.js.bytecode-cache
stress/class-subclassing-string.js.bytecode-cache
stress/class-syntax-tdz-in-catch.js.bytecode-cache
stress/inserted-recovery-with-set-last-index.js.bytecode-cache
stress/for-in-invalidate-context-weird-assignments.js.bytecode-cache
stress/symbol-toprimitive-errors.js.bytecode-cache
stress/typedarray-getownproperty-not-configurable.js.bytecode-cache
stress/object-prevent-extensions-accept-non-object.js.bytecode-cache
v8-v6/v8-earley-boyer.js.bytecode-cache
stress/pad-start-calls-repeat-character-with-double.js.bytecode-cache
stress/regexp-with-runtime-syntax-errors.js.bytecode-cache
stress/pow-stable-results.js.bytecode-cache
stress/object-values.js.bytecode-cache
stress/instanceof-hit-two-objects-then-another.js.bytecode-cache
stress/scoped-arguments-check-array.js.bytecode-cache
stress/string-iterators.js.bytecode-cache
stress/instanceof-prototype-change.js.bytecode-cache
stress/get-by-val-string.js.bytecode-cache
stress/instanceof-dynamic-proxy-loop.js.bytecode-cache
stress/typedarray-fill.js.bytecode-cache
stress/has-instance-exception-check.js.bytecode-cache
stress/typedarray-hasOwnProperty-out-of-bounds.js.bytecode-cache
stress/instanceof-non-object-prototype.js.bytecode-cache
stress/regress-168546.js.bytecode-cache
stress/symbol-hasInstance.js.bytecode-cache
stress/generator-yield-star.js.bytecode-cache
stress/proxy-set-prototype-of.js.bytecode-cache
stress/array-reverse-proxy.js.bytecode-cache
stress/reflect-set.js.bytecode-cache
stress/regress-163748.js.bytecode-cache
stress/regress-179140.js.bytecode-cache
stress/string-instanceof.js.bytecode-cache
stress/fold-load-varargs-arity-check-fail-barely.js.bytecode-cache
stress/map-set-create-bucket.js.bytecode-cache
stress/ai-create-this-to-new-object.js.bytecode-cache
stress/async-iteration-for-await-of-syntax.js.bytecode-cache
stress/promise-species-functions.js.bytecode-cache
stress/modify-map-during-iteration.js.bytecode-cache
stress/typedarray-findIndex.js.bytecode-cache
stress/destructuring-assignment-accepts-iterables.js.bytecode-cache
stress/v8-earley-boyer-strict.js.bytecode-cache
stress/sampling-profiler-basic.js.bytecode-cache
stress/array-flatten.js.bytecode-cache
ChakraCore.yaml/ChakraCore/test/es6/letconst_global.js.default
stress/proxy-with-unbalanced-getter-setter.js.bytecode-cache
stress/super-property-access-object-literal-to-this-2.js.bytecode-cache
stress/async-await-reserved-word.js.bytecode-cache
microbenchmarks/instanceof-tricky-dynamic.js.bytecode-cache
microbenchmarks/for-of-array.js.bytecode-cache
stress/tagged-templates-syntax.js.bytecode-cache
stress/class-syntax-double-constructor.js.bytecode-cache
stress/weakmap-cse-set-break.js.bytecode-cache
apiTests

[Yusuke Suzuki]

Created attachment 361219 [details]
WIP

[Yusuke Suzuki]

Created attachment 361238 [details]
WIP

[EWS Watchlist]

Attachment 361238 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 361238 [details]
WIP

Attachment 361238 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11045979

New failing tests:
streams/readable-byte-stream-controller.html

[EWS Watchlist]

Created attachment 361253 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361238 [details]
WIP

Attachment 361238 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11046907

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 361261 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361238 [details]
WIP

Attachment 361238 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11046818

New failing tests:
streams/readable-byte-stream-controller.html

[EWS Watchlist]

Created attachment 361264 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 361238 [details]
WIP

Attachment 361238 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/11046679

New failing tests:
ChakraCore.yaml/ChakraCore/test/es6/letconst_global.js.default
apiTests

[Yusuke Suzuki]

Created attachment 361266 [details]
Patch

[EWS Watchlist]

Comment on attachment 361266 [details]
Patch

Attachment 361266 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/11048330

New failing tests:
ChakraCore.yaml/ChakraCore/test/es6/letconst_global.js.default
apiTests

[Yusuke Suzuki]

(In reply to Build Bot from comment #14)
> Comment on attachment 361266 [details]
> Patch
> 
> Attachment 361266 [details] did not pass jsc-ews (mac):
> Output: https://webkit-queues.webkit.org/results/11048330
> 
> New failing tests:
> ChakraCore.yaml/ChakraCore/test/es6/letconst_global.js.default
> apiTests

Interesting. This test depends on the order in SymbolTable, and it is not guaranteed in JSC. Just skipping.

[Yusuke Suzuki]

Created attachment 361278 [details]
Patch

[EWS Watchlist]

Comment on attachment 361278 [details]
Patch

Attachment 361278 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11050216

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 361282 [details]
Archive of layout-test-results from ews114 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Yusuke Suzuki]

Comment on attachment 361278 [details]
Patch

Looking into the crash in debug build.

[Yusuke Suzuki]

Created attachment 361284 [details]
Patch

[Michael Saboff]

Comment on attachment 361284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361284&action=review

r=me with some suggested comment and whitespace changes.

> Source/JavaScriptCore/ChangeLog:9
> +        PrivateNames take much memory in intial JSC footprint. Since BuiltinNames have Identifier fields corresponding to these PrivateNames,
> +        sizeof(BuiltinNames) is about 6KB. It also maintains hash tables for "PublicName to PrivateName" and "PrivateName to PublicName",

Wording seems a little awkward.  How about:
    PrivateNames account for a lot of memory in the initial JSC footprint. BuiltinNames have Identifier fields corresponding to these PrivateNames 
    which makes the sizeof(BuiltinNames) about 6KB. ...

> Source/JavaScriptCore/ChangeLog:16
> +        2. If PrivateName is not actually a private name (we introduced hacky mapping like "@iteratorSymbol" => Symbol.iterator),

Did you mean "If PrivateName is not actually a *public* name ..."?

> Source/JavaScriptCore/runtime/CommonIdentifiers.cpp:64
> +    

Delete this extraneous whitespace.

[Yusuke Suzuki]

Comment on attachment 361284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361284&action=review

>> Source/JavaScriptCore/ChangeLog:9
>> +        sizeof(BuiltinNames) is about 6KB. It also maintains hash tables for "PublicName to PrivateName" and "PrivateName to PublicName",
> 
> Wording seems a little awkward.  How about:
>     PrivateNames account for a lot of memory in the initial JSC footprint. BuiltinNames have Identifier fields corresponding to these PrivateNames 
>     which makes the sizeof(BuiltinNames) about 6KB. ...

Nice, fixed!

>> Source/JavaScriptCore/ChangeLog:16
>> +        2. If PrivateName is not actually a private name (we introduced hacky mapping like "@iteratorSymbol" => Symbol.iterator),
> 
> Did you mean "If PrivateName is not actually a *public* name ..."?

We have a bit interesting hack in BuiltinNames. After this http://trac.webkit.org/r201825, PublicName to PrivateName table sometimes has non-private symbols as PrivateName.
This means that our mapping is like "iteratorSymbol" (public name) => Symbol.iterator (its content is "Symbol.iterator"). Since (1) we cannot change the content of Symbol.iterator because it is specified in the spec and (2) "Symbol.iterator" form is not one identifier and breaks the hack introduced in r201825, we need to keep the public name "iteratorSymbol" while the content of the register symbol is "Symbol.iterator". So we need special care to get "iteratorSymbol" value from "Symbol.iterator".

>> Source/JavaScriptCore/runtime/CommonIdentifiers.cpp:64
>> +    
> 
> Delete this extraneous whitespace.

Oops, thanks. Fixed.

[Yusuke Suzuki]

Committed r241104: <https://trac.webkit.org/changeset/241104>

[Radar WebKit Bug Importer]

<rdar://problem/47866081>