RESOLVED FIXED 194269
[LFC][IFC] collectInlineContent should use pre-computed margins, paddings and borders 
https://bugs.webkit.org/show_bug.cgi?id=194269
Summary [LFC][IFC] collectInlineContent should use pre-computed margins, paddings and...
zalan
Reported 2019-02-04 19:10:08 PST
This is in preparation for using the same code patch by the preferred width computation (currently broken).
Attachments
Patch (8.87 KB, patch)
2019-02-04 19:20 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2019-02-04 19:20:34 PST
Created attachment 361151 [details] Patch
Antti Koivisto
Comment 2 2019-02-05 07:30:53 PST
Comment on attachment 361151 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361151&action=review > Source/WebCore/layout/layouttree/LayoutBox.h:158 > - unsigned m_baseTypeFlags : 4; > + unsigned m_baseTypeFlags : 5; OptionSet would avoid these problems too!
WebKit Commit Bot
Comment 3 2019-02-05 08:01:35 PST
Comment on attachment 361151 [details] Patch Clearing flags on attachment: 361151 Committed r240975: <https://trac.webkit.org/changeset/240975>
WebKit Commit Bot
Comment 4 2019-02-05 08:01:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-02-05 08:02:40 PST
<rdar://problem/47818132>
Note You need to log in before you can comment on or make changes to this bug.