Bug 194269 - [LFC][IFC] collectInlineContent should use pre-computed margins, paddings and borders
Summary: [LFC][IFC] collectInlineContent should use pre-computed margins, paddings and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-04 19:10 PST by zalan
Modified: 2019-02-05 08:02 PST (History)
6 users (show)

See Also:

Attachments
Patch (8.87 KB, patch)
2019-02-04 19:20 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-02-04 19:10:08 PST 
This is in preparation for using the same code patch by the preferred width computation (currently broken).
Comment 1 zalan 2019-02-04 19:20:34 PST 
Created attachment 361151 [details]
Patch
Comment 2 Antti Koivisto 2019-02-05 07:30:53 PST 
Comment on attachment 361151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361151&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:158
> -    unsigned m_baseTypeFlags : 4;
> +    unsigned m_baseTypeFlags : 5;

OptionSet would avoid these problems too!
Comment 3 WebKit Commit Bot 2019-02-05 08:01:35 PST 
Comment on attachment 361151 [details]
Patch

Clearing flags on attachment: 361151

Committed r240975: <https://trac.webkit.org/changeset/240975>
Comment 4 WebKit Commit Bot 2019-02-05 08:01:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-02-05 08:02:40 PST 
<rdar://problem/47818132>