Bug 194267 - [WinCairo] Turn ENABLE_RESOURCE_LOAD_STATISTICS on
Summary: [WinCairo] Turn ENABLE_RESOURCE_LOAD_STATISTICS on
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on: 194913
Blocks:
  Show dependency treegraph
 
Reported: 2019-02-04 18:34 PST by Fujii Hironori
Modified: 2019-02-28 19:36 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.19 KB, patch)
2019-02-21 17:19 PST, Don Olmstead
no flags Details | Formatted Diff | Diff
Layout Test Results (223.82 KB, application/x-zip-compressed)
2019-02-21 17:20 PST, Don Olmstead
no flags Details
Patch (1.19 KB, patch)
2019-02-28 16:25 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-02-04 18:34:11 PST
[WinCairo] assertion failed by running http/tests/resourceLoadStatistics some tests

Debug build of WebKitTestRunner is failing while DumpRenderTree don't fail.

> ASSERTION FAILED: m_notificationCallback
> ..\..\Source\WebCore\loader/ResourceLoadObserver.cpp(403) : notifyObserver
> 1   00007FF8A98F1429 WTFCrash
> 2   00007FF8734E1330 WTFCrashWithInfo
> 3   00007FF874AEFA43 WebCore::ResourceLoadObserver::notifyObserver
> 4   00007FF873D17216 WKBundleResourceLoadStatisticsNotifyObserver
> 5   00007FF89F44D277 WTR::InjectedBundle::statisticsNotifyObserver
> 6   00007FF89F470EE6 WTR::TestRunner::statisticsNotifyObserver
> 7   00007FF89F49D8F1 WTR::JSTestRunner::statisticsNotifyObserver
> 8   00007FF87AF7083F JSC::APICallbackFunction::call<JSC::JSCallbackFunction>
> 9   000001BC00001027
> LEAK: 1 WebPageProxy

http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-redirect-collusion.html failed unexpectedly (WebProcess crashed [pid=7796])
http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html failed unexpectedly (WebProcess crashed [pid=10804])
http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html failed unexpectedly (WebProcess crashed [pid=9280])
http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=3320])
http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=10308])
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=16124])
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=13184])
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=13532])
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=15324])
http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=7788])
http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=12960])
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=8620])
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=11424])
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=7292])
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=8264])
Comment 1 Fujii Hironori 2019-02-04 21:50:13 PST
ENABLE_RESOURCE_LOAD_STATISTICS should be defined for it.
GTK port skips http/tests/resourceLoadStatistics/ at the moment.
Comment 2 Fujii Hironori 2019-02-04 21:50:22 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2019-02-21 17:19:35 PST
Created attachment 362673 [details]
Patch
Comment 4 Don Olmstead 2019-02-21 17:20:20 PST
Created attachment 362674 [details]
Layout Test Results
Comment 5 Don Olmstead 2019-02-28 16:25:22 PST
Created attachment 363273 [details]
Patch
Comment 6 Brent Fulgham 2019-02-28 16:55:39 PST
Yesss!!!
Comment 7 WebKit Commit Bot 2019-02-28 19:35:39 PST
Comment on attachment 363273 [details]
Patch

Clearing flags on attachment: 363273

Committed r242254: <https://trac.webkit.org/changeset/242254>
Comment 8 WebKit Commit Bot 2019-02-28 19:35:41 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-02-28 19:36:21 PST
<rdar://problem/48498694>