Bug 194267 – [WinCairo] Turn ENABLE_RESOURCE_LOAD_STATISTICS on

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Fujii Hironori]

[WinCairo] assertion failed by running http/tests/resourceLoadStatistics some tests

Debug build of WebKitTestRunner is failing while DumpRenderTree don't fail.

> ASSERTION FAILED: m_notificationCallback
> ..\..\Source\WebCore\loader/ResourceLoadObserver.cpp(403) : notifyObserver
> 1   00007FF8A98F1429 WTFCrash
> 2   00007FF8734E1330 WTFCrashWithInfo
> 3   00007FF874AEFA43 WebCore::ResourceLoadObserver::notifyObserver
> 4   00007FF873D17216 WKBundleResourceLoadStatisticsNotifyObserver
> 5   00007FF89F44D277 WTR::InjectedBundle::statisticsNotifyObserver
> 6   00007FF89F470EE6 WTR::TestRunner::statisticsNotifyObserver
> 7   00007FF89F49D8F1 WTR::JSTestRunner::statisticsNotifyObserver
> 8   00007FF87AF7083F JSC::APICallbackFunction::call<JSC::JSCallbackFunction>
> 9   000001BC00001027
> LEAK: 1 WebPageProxy

http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-redirect-collusion.html failed unexpectedly (WebProcess crashed [pid=7796])
http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html failed unexpectedly (WebProcess crashed [pid=10804])
http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html failed unexpectedly (WebProcess crashed [pid=9280])
http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=3320])
http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=10308])
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=16124])
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=13184])
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=13532])
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=15324])
http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=7788])
http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=12960])
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=8620])
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=11424])
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html failed unexpectedly (WebProcess crashed [pid=7292])
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html failed unexpectedly (WebProcess crashed [pid=8264])

[Fujii Hironori]

ENABLE_RESOURCE_LOAD_STATISTICS should be defined for it.
GTK port skips http/tests/resourceLoadStatistics/ at the moment.

[Fujii Hironori]

ENABLE_RESOURCE_LOAD_STATISTICS should be defined for it.
GTK port skips http/tests/resourceLoadStatistics/ at the moment.

[Don Olmstead]

Created attachment 362673 [details]
Patch

[Don Olmstead]

Created attachment 362674 [details]
Layout Test Results

[Don Olmstead]

Created attachment 363273 [details]
Patch

[Brent Fulgham]

Yesss!!!

[WebKit Commit Bot]

Comment on attachment 363273 [details]
Patch

Clearing flags on attachment: 363273

Committed r242254: <https://trac.webkit.org/changeset/242254>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48498694>