Bug 19426 - LOW_BANDWIDTH_DISPLAY build broken
Summary: LOW_BANDWIDTH_DISPLAY build broken
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2008-06-06 21:22 PDT by David Krause
Modified: 2008-06-22 18:03 PDT (History)
1 user (show)

See Also:

Proposed patch (2.12 KB, patch)
2008-06-08 20:04 PDT, David Krause
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Krause 2008-06-06 21:22:46 PDT
Using a recent nightly (r34342), it seems that the build will not finish if USE(LOW_BANDWIDTH_DISPLAY) is set.  WebCore/loader/FrameLoader.cpp fails to compile because of 3 lines of code that look like:


Looking back, it appears that the changes on changeset 31834 may have introduced this breakage.

The build at least completes if I change ref to addClient and deref to removeClient.

Can an expert confirm this?  If so, I'll submit a patch changing this.
Comment 1 David Krause 2008-06-08 20:04:11 PDT
Created attachment 21587 [details]
Proposed patch

Proposed patch uploaded that changes the three references causing the build to break.
Comment 2 Darin Adler 2008-06-08 20:07:18 PDT
Comment on attachment 21587 [details]
Proposed patch

Comment 3 Mark Rowe (bdash) 2008-06-22 18:03:11 PDT
Landed in r34733.