RESOLVED FIXED 194248
Change llint operand macros to inline functions 
https://bugs.webkit.org/show_bug.cgi?id=194248
Summary Change llint operand macros to inline functions
Keith Miller
Reported 2019-02-04 16:14:10 PST
Change llint operand macros to inline functions
Attachments
Patch (27.21 KB, patch)
2019-02-04 16:15 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (26.91 KB, patch)
2019-02-04 16:45 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-02-04 16:15:29 PST
Created attachment 361120 [details] Patch
Mark Lam
Comment 2 2019-02-04 16:40:13 PST
Comment on attachment 361120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361120&action=review > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:145 > + getOperand(exec, bytecode.m_dst) = __r_returnValue; \ How. An this work? You’re assigning to a returned value.
Keith Miller
Comment 3 2019-02-04 16:45:01 PST
Created attachment 361129 [details] Patch
Keith Miller
Comment 4 2019-02-04 16:45:42 PST
(In reply to Mark Lam from comment #2) > Comment on attachment 361120 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=361120&action=review > > > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:145 > > + getOperand(exec, bytecode.m_dst) = __r_returnValue; \ > > How. An this work? You’re assigning to a returned value. Sorry, that happened from a bad find-replace. I fixed it.
Mark Lam
Comment 5 2019-02-04 17:11:44 PST
Comment on attachment 361129 [details] Patch r=me if EWS bits are green.
Mark Lam
Comment 6 2019-02-04 17:12:34 PST
(In reply to Mark Lam from comment #5) > Comment on attachment 361129 [details] > Patch > > r=me if EWS bits are green. Autocorrect fail: /bits/bots/
Keith Miller
Comment 7 2019-02-04 18:56:54 PST
(In reply to Mark Lam from comment #6) > (In reply to Mark Lam from comment #5) > > Comment on attachment 361129 [details] > > Patch > > > > r=me if EWS bits are green. > > Autocorrect fail: /bits/bots/ There are bits in the colors of the pixels so it's not totally inaccurate!
WebKit Commit Bot
Comment 8 2019-02-04 19:23:10 PST
Comment on attachment 361129 [details] Patch Clearing flags on attachment: 361129 Committed r240960: <https://trac.webkit.org/changeset/240960>
WebKit Commit Bot
Comment 9 2019-02-04 19:23:12 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-02-04 19:24:30 PST
<rdar://problem/47808722>
Note You need to log in before you can comment on or make changes to this bug.