Bug 194248 - Change llint operand macros to inline functions
Summary: Change llint operand macros to inline functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-04 16:14 PST by Keith Miller
Modified: 2019-02-04 19:24 PST (History)
6 users (show)

See Also:


Attachments
Patch (27.21 KB, patch)
2019-02-04 16:15 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (26.91 KB, patch)
2019-02-04 16:45 PST, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2019-02-04 16:14:10 PST
Change llint operand macros to inline functions
Comment 1 Keith Miller 2019-02-04 16:15:29 PST
Created attachment 361120 [details]
Patch
Comment 2 Mark Lam 2019-02-04 16:40:13 PST
Comment on attachment 361120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361120&action=review

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:145
> +        getOperand(exec, bytecode.m_dst) = __r_returnValue;          \

How. An this work?  You’re assigning to a returned value.
Comment 3 Keith Miller 2019-02-04 16:45:01 PST
Created attachment 361129 [details]
Patch
Comment 4 Keith Miller 2019-02-04 16:45:42 PST
(In reply to Mark Lam from comment #2)
> Comment on attachment 361120 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361120&action=review
> 
> > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:145
> > +        getOperand(exec, bytecode.m_dst) = __r_returnValue;          \
> 
> How. An this work?  You’re assigning to a returned value.

Sorry, that happened from a bad find-replace. I fixed it.
Comment 5 Mark Lam 2019-02-04 17:11:44 PST
Comment on attachment 361129 [details]
Patch

r=me if EWS bits are green.
Comment 6 Mark Lam 2019-02-04 17:12:34 PST
(In reply to Mark Lam from comment #5)
> Comment on attachment 361129 [details]
> Patch
> 
> r=me if EWS bits are green.

Autocorrect fail: /bits/bots/
Comment 7 Keith Miller 2019-02-04 18:56:54 PST
(In reply to Mark Lam from comment #6)
> (In reply to Mark Lam from comment #5)
> > Comment on attachment 361129 [details]
> > Patch
> > 
> > r=me if EWS bits are green.
> 
> Autocorrect fail: /bits/bots/

There are bits in the colors of the pixels so it's not totally inaccurate!
Comment 8 WebKit Commit Bot 2019-02-04 19:23:10 PST
Comment on attachment 361129 [details]
Patch

Clearing flags on attachment: 361129

Committed r240960: <https://trac.webkit.org/changeset/240960>
Comment 9 WebKit Commit Bot 2019-02-04 19:23:12 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-02-04 19:24:30 PST
<rdar://problem/47808722>