Change llint operand macros to inline functions
Created attachment 361120 [details] Patch
Comment on attachment 361120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361120&action=review > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:145 > + getOperand(exec, bytecode.m_dst) = __r_returnValue; \ How. An this work? You’re assigning to a returned value.
Created attachment 361129 [details] Patch
(In reply to Mark Lam from comment #2) > Comment on attachment 361120 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=361120&action=review > > > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:145 > > + getOperand(exec, bytecode.m_dst) = __r_returnValue; \ > > How. An this work? You’re assigning to a returned value. Sorry, that happened from a bad find-replace. I fixed it.
Comment on attachment 361129 [details] Patch r=me if EWS bits are green.
(In reply to Mark Lam from comment #5) > Comment on attachment 361129 [details] > Patch > > r=me if EWS bits are green. Autocorrect fail: /bits/bots/
(In reply to Mark Lam from comment #6) > (In reply to Mark Lam from comment #5) > > Comment on attachment 361129 [details] > > Patch > > > > r=me if EWS bits are green. > > Autocorrect fail: /bits/bots/ There are bits in the colors of the pixels so it's not totally inaccurate!
Comment on attachment 361129 [details] Patch Clearing flags on attachment: 361129 Committed r240960: <https://trac.webkit.org/changeset/240960>
All reviewed patches have been landed. Closing bug.
<rdar://problem/47808722>