Bug 194230 - Can't temporarily force light or dark appearance on a page in a WebView
Summary: Can't temporarily force light or dark appearance on a page in a WebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-04 11:08 PST by Timothy Hatcher
Modified: 2019-02-04 16:29 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2019-02-04 11:15 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (2.20 KB, patch)
2019-02-04 13:04 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2019-02-04 11:08:51 PST 
Needed by clients to switch the appearance for DOM processing explicitly in light or dark mode.

Similar to the WK2 version added in bug 193327.
Comment 1 Timothy Hatcher 2019-02-04 11:15:12 PST Comment hidden (obsolete)
Comment 2 Tim Horton 2019-02-04 11:40:20 PST 
Comment on attachment 361075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361075&action=review

> Source/WebKitLegacy/mac/WebView/WebViewPrivate.h:325
> +- (void)_setUseDarkAppearance:(BOOL)useDarkAppearance;

Why not a @property with a getter?
Comment 3 Timothy Hatcher 2019-02-04 13:04:57 PST 
Created attachment 361088 [details]
Patch
Comment 4 WebKit Commit Bot 2019-02-04 16:28:29 PST 
Comment on attachment 361088 [details]
Patch

Clearing flags on attachment: 361088

Committed r240948: <https://trac.webkit.org/changeset/240948>
Comment 5 WebKit Commit Bot 2019-02-04 16:28:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-02-04 16:29:37 PST 
<rdar://problem/47804744>