The following layout test is flaky on Mac WK2 Debug http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page.html Probable cause: Appears to be flaky timeout or missing failure as of 239333. Reproducible with: run-webkit-tests --root d239506 http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page.html --iterations 500 -f --debug --exit-after-n-failures=1 --no-retry-failures Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcookies%2Fsame-site%2Ffetch-after-top-level-navigation-from-cross-origin-page.html Assertion failure: ASSERTION FAILED: m_uncommittedState.state == State::Committed /Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/PageLoadState.cpp(298) : void WebKit::PageLoadState::didFinishLoad(const Transaction::Token &) 1 0x10fa349e9 WTFCrash 2 0x119be42cb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11a33ee3d WebKit::PageLoadState::didFinishLoad(WebKit::PageLoadState::Transaction::Token const&) 4 0x11a4f94c2 WebKit::WebPageProxy::didFinishLoadForFrame(unsigned long long, unsigned long long, WebKit::UserData const&)
Forgot to link crash log: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r240918%20(1446)/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-stderr.txt
<rdar://problem/47820247>
Did https://bugs.webkit.org/show_bug.cgi?id=193740 not fix this? It was working for me locally.
It did not, there's a crash with newer r240967: https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20(Tests)/builds/1461
(In reply to Alexey Proskuryakov from comment #4) > It did not, there's a crash with newer r240967: > https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20(Tests)/ > builds/1461 Ok, thanks. I'll investigate further.
Created attachment 362431 [details] Patch
Comment on attachment 362431 [details] Patch Rejecting attachment 362431 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 362431, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=362431&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=194225&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 362431 from bug 194225. Fetching: https://bugs.webkit.org/attachment.cgi?id=362431 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/mac-wk2/TestExpectations Hunk #1 FAILED at 911. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac-wk2/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/11208643
Created attachment 362530 [details] Update TestExpectations
Comment on attachment 362530 [details] Update TestExpectations Clearing flags on attachment: 362530 Committed r241831: <https://trac.webkit.org/changeset/241831>
Committed r243255: <https://trac.webkit.org/changeset/243255>