Bug 194224 - Protect globalWebSocketStreamMap with a Lock
Summary: Protect globalWebSocketStreamMap with a Lock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-04 10:13 PST by Alex Christensen
Modified: 2019-02-05 07:38 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.14 KB, patch)
2019-02-04 10:13 PST, Alex Christensen 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-02-04 10:13:18 PST 
Protect globalWebSocketStreamMap with a Lock
Comment 1 Alex Christensen 2019-02-04 10:13:33 PST 
Created attachment 361069 [details]
Patch
Comment 2 Alex Christensen 2019-02-04 10:13:35 PST 
<rdar://problem/47581081>
Comment 3 Ryosuke Niwa 2019-02-04 14:39:28 PST 
Comment on attachment 361069 [details]
Patch

Do we know which thread/function may end up accessing globalWebSocketStreamMap()?
Can we mention that in the change log if so?
Otherwise, can we mention that it's a speculative fix?
Comment 4 Alex Christensen 2019-02-04 14:54:21 PST 
I think this is related to WebSocket use from workers.  I can put such in the ChangeLog after review.
Comment 5 Ryosuke Niwa 2019-02-04 16:33:06 PST 
Comment on attachment 361069 [details]
Patch

Okay, let's hope the rest of the code is thread safe.
Comment 6 Alex Christensen 2019-02-05 07:38:36 PST 
http://trac.webkit.org/r240974