Bug 194216 - [WPE] Do not use a sync IPC message to send the host FD to the web process
Summary: [WPE] Do not use a sync IPC message to send the host FD to the web process
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2019-02-04 03:01 PST by Carlos Garcia Campos
Modified: 2019-02-11 00:35 PST (History)
3 users (show)

See Also:

Patch (23.75 KB, patch)
2019-02-04 03:03 PST, Carlos Garcia Campos
darin: review+
Details | Formatted Diff | Diff
Patch for landing (23.95 KB, patch)
2019-02-10 23:05 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-02-04 03:01:05 PST
It can be sent as a web page creation parameter instead.
Comment 1 Carlos Garcia Campos 2019-02-04 03:03:31 PST
Created attachment 361049 [details]
Comment 2 Darin Adler 2019-02-10 16:48:45 PST
Comment on attachment 361049 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=361049&action=review

Not thrilled with the use of "FD" in the patch.

> Source/WebKit/UIProcess/API/wpe/PageClientImpl.h:146
> +    IPC::Attachment hostFD();

This should say "override" or "final"; applies even though the underlying function is a pure virtual. My preference is final, but it seems we have a mix in this file.

> Source/WebKit/UIProcess/API/wpe/WPEView.h:57
> +    virtual ~View() = default;

I suggest we consider just deleting this line entirely, because this is what happens if we don’t declare the destructor at all, and I think it’s elegant to just let that happen. OK this way too, though.

> Source/WebKit/UIProcess/PageClient.h:488
> +    virtual IPC::Attachment hostFD() = 0;
> +#endif

This is a messy pattern, but I suppose it’s what we are using for lots of other things above, so it’s not great for me to complain just about this one.
Comment 3 Carlos Garcia Campos 2019-02-10 23:05:44 PST
Created attachment 361660 [details]
Patch for landing
Comment 4 Carlos Garcia Campos 2019-02-11 00:12:11 PST
Committed r241260: <https://trac.webkit.org/changeset/241260>