Bug 194209 - REGRESSION(r240785): [SOUP] Broke cookie persistent storage
Summary: REGRESSION(r240785): [SOUP] Broke cookie persistent storage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 194075
  Show dependency tree / graph
 
Reported: 2019-02-03 19:48 PST by Michael Catanzaro
Modified: 2019-02-06 00:07 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.60 KB, patch)
2019-02-05 12:02 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-02-03 19:48:05 PST 
I broke cookie persistent storage in r240785 and should probably fix it.
Comment 1 Carlos Garcia Campos 2019-02-04 00:09:11 PST 
Should probably fix it?
Comment 2 Michael Catanzaro 2019-02-04 07:05:14 PST 
Yes, probably, unless we want all cookies to be lost at the end of the session. :)

Seriously now, I made the mistake of assuming TestWebKitCookieManager would notice if I broke cookies. We should probably check somewhere that the persistent storage file is created.
Comment 3 Michael Catanzaro 2019-02-05 12:02:44 PST 
Created attachment 361207 [details]
Patch
Comment 4 WebKit Commit Bot 2019-02-06 00:06:02 PST 
Comment on attachment 361207 [details]
Patch

Clearing flags on attachment: 361207

Committed r241013: <https://trac.webkit.org/changeset/241013>
Comment 5 WebKit Commit Bot 2019-02-06 00:06:04 PST 
All reviewed patches have been landed.  Closing bug.