Bug 194181 - Make sure to remove the device observer in AVVideoCaptureSource
Summary: Make sure to remove the device observer in AVVideoCaptureSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-01 17:33 PST by youenn fablet
Modified: 2019-02-04 10:47 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2019-02-01 17:36 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2019-02-01 17:46 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2019-02-04 09:57 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-02-01 17:33:42 PST 
Make sure to remove the device observer in AVVideoCaptureSource
Comment 1 youenn fablet 2019-02-01 17:34:05 PST 
<rdar://problem/47739247>
Comment 2 youenn fablet 2019-02-01 17:36:40 PST 
Created attachment 360929 [details]
Patch
Comment 3 youenn fablet 2019-02-01 17:46:54 PST 
Created attachment 360934 [details]
Patch
Comment 4 Eric Carlson 2019-02-01 19:19:10 PST 
Comment on attachment 360934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360934&action=review

r=me

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:206
> +{

Might be worth ASSERTing !m_session?

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:213
> +    [m_session removeObserver:m_objcObserver.get() forKeyPath:@"running"];

Might be worth ASSERTing m_session?
Comment 5 youenn fablet 2019-02-04 09:57:48 PST 
Created attachment 361066 [details]
Patch
Comment 6 WebKit Commit Bot 2019-02-04 10:47:28 PST 
Comment on attachment 361066 [details]
Patch

Clearing flags on attachment: 361066

Committed r240930: <https://trac.webkit.org/changeset/240930>
Comment 7 WebKit Commit Bot 2019-02-04 10:47:30 PST 
All reviewed patches have been landed.  Closing bug.