Bug 194171 - Web Inspector: Make WI.ColumnChart a WI.View subclass
Summary: Web Inspector: Make WI.ColumnChart a WI.View subclass
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-01 13:20 PST by Joseph Pecoraro
Modified: 2019-02-01 13:41 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (4.23 KB, patch)
2019-02-01 13:20 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (4.23 KB, patch)
2019-02-01 13:28 PST, Joseph Pecoraro 		drousso: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-02-01 13:20:10 PST 
Make WI.ColumnChart a WI.View subclass
Comment 1 Joseph Pecoraro 2019-02-01 13:20:44 PST 
Created attachment 360888 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2019-02-01 13:28:37 PST 
Created attachment 360890 [details]
[PATCH] Proposed Fix
Comment 3 Devin Rousso 2019-02-01 13:36:50 PST 
Comment on attachment 360890 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=360888&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/ColumnChart.js:51
> +        this._svgElement = this.element.appendChild(createSVGElement("svg"));

I think it's worth adding `preservesAspectRatio="none"` like many of the other charts, so that if we ever use it elsewhere it also supports stretching.

    this._svgElement.setAttribute("preserveAspectRatio", "none");
Comment 4 Joseph Pecoraro 2019-02-01 13:41:01 PST 
https://trac.webkit.org/changeset/240872/webkit
Comment 5 Radar WebKit Bug Importer 2019-02-01 13:41:27 PST 
<rdar://problem/47747770>