WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
194171
Web Inspector: Make WI.ColumnChart a WI.View subclass
https://bugs.webkit.org/show_bug.cgi?id=194171
Summary
Web Inspector: Make WI.ColumnChart a WI.View subclass
Joseph Pecoraro
Reported
2019-02-01 13:20:10 PST
Make WI.ColumnChart a WI.View subclass
Attachments
[PATCH] Proposed Fix
(4.23 KB, patch)
2019-02-01 13:20 PST
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
[PATCH] Proposed Fix
(4.23 KB, patch)
2019-02-01 13:28 PST
,
Joseph Pecoraro
hi
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2019-02-01 13:20:44 PST
Created
attachment 360888
[details]
[PATCH] Proposed Fix
Joseph Pecoraro
Comment 2
2019-02-01 13:28:37 PST
Created
attachment 360890
[details]
[PATCH] Proposed Fix
Devin Rousso
Comment 3
2019-02-01 13:36:50 PST
Comment on
attachment 360890
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=360888&action=review
rs=me
> Source/WebInspectorUI/UserInterface/Views/ColumnChart.js:51 > + this._svgElement = this.element.appendChild(createSVGElement("svg"));
I think it's worth adding `preservesAspectRatio="none"` like many of the other charts, so that if we ever use it elsewhere it also supports stretching. this._svgElement.setAttribute("preserveAspectRatio", "none");
Joseph Pecoraro
Comment 4
2019-02-01 13:41:01 PST
https://trac.webkit.org/changeset/240872/webkit
Radar WebKit Bug Importer
Comment 5
2019-02-01 13:41:27 PST
<
rdar://problem/47747770
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug