Bug 194168 - [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
Summary: [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred an...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 193908
  Show dependency tree / graph
 
Reported: 2019-02-01 11:31 PST by zalan
Modified: 2019-02-04 20:55 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.06 KB, patch)
2019-02-01 11:43 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (24.28 KB, patch)
2019-02-04 13:42 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (24.28 KB, patch)
2019-02-04 13:43 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-02-01 11:31:41 PST 
Document::Interactive means we already finished parsing the main document though we still might have pending async/deferred scripts to complete.
Comment 1 zalan 2019-02-01 11:43:30 PST 
Created attachment 360880 [details]
Patch
Comment 2 zalan 2019-02-01 11:43:41 PST 
Needs test case :(
Comment 3 Simon Fraser (smfr) 2019-02-01 12:56:19 PST 
Comment on attachment 360880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360880&action=review

> Source/WebCore/ChangeLog:8
> +        First paint should not be block by async or deferred scripts.

be block by
Comment 4 zalan 2019-02-04 13:42:37 PST 
Created attachment 361091 [details]
Patch
Comment 5 zalan 2019-02-04 13:43:26 PST 
Created attachment 361092 [details]
Patch
Comment 6 WebKit Commit Bot 2019-02-04 14:19:46 PST 
Comment on attachment 361092 [details]
Patch

Clearing flags on attachment: 361092

Committed r240942: <https://trac.webkit.org/changeset/240942>
Comment 7 WebKit Commit Bot 2019-02-04 14:19:48 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-02-04 14:20:31 PST 
<rdar://problem/47799428>