Bug 194167 - [JSC] Unify CodeBlock IsoSubspaces
Summary: [JSC] Unify CodeBlock IsoSubspaces
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 193606
  Show dependency treegraph
 
Reported: 2019-02-01 11:08 PST by Yusuke Suzuki
Modified: 2019-02-04 17:34 PST (History)
6 users (show)

See Also:


Attachments
Patch (16.68 KB, patch)
2019-02-01 11:50 PST, Yusuke Suzuki
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-02-01 11:08:12 PST
[JSC] Unify CodeBlock IsoSubspaces
Comment 1 Yusuke Suzuki 2019-02-01 11:50:09 PST
Created attachment 360881 [details]
Patch
Comment 2 Saam Barati 2019-02-01 11:54:38 PST
Comment on attachment 360881 [details]
Patch

r=me
Comment 3 Saam Barati 2019-02-01 11:55:18 PST
Comment on attachment 360881 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360881&action=review

> Source/JavaScriptCore/interpreter/Interpreter.cpp:1047
> +    UnlinkedEvalCodeBlock* unlinkedCodeBlock = jsDynamicCast<UnlinkedEvalCodeBlock*>(vm, codeBlock->unlinkedCodeBlock());

Why not just codeBlock->unlinkedEvalCodeBlock()?
Comment 4 Yusuke Suzuki 2019-02-01 13:09:55 PST
Comment on attachment 360881 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360881&action=review

>> Source/JavaScriptCore/interpreter/Interpreter.cpp:1047
>> +    UnlinkedEvalCodeBlock* unlinkedCodeBlock = jsDynamicCast<UnlinkedEvalCodeBlock*>(vm, codeBlock->unlinkedCodeBlock());
> 
> Why not just codeBlock->unlinkedEvalCodeBlock()?

It sound OK. Fixed.
Comment 5 Yusuke Suzuki 2019-02-01 13:14:38 PST
Committed r240864: <https://trac.webkit.org/changeset/240864>
Comment 6 Radar WebKit Bug Importer 2019-02-01 13:15:28 PST
<rdar://problem/47746857>