Bug 194166 – Force settings.acceleratedCompositingEnabled() to true for WebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Force settings.acceleratedCompositingEnabled() to true for WebKit

[Simon Fraser (smfr)]

Created attachment 360873 [details]
Patch

[Simon Fraser (smfr)]

<rdar://problem/47694328>

[WebKit Commit Bot]

Comment on attachment 360873 [details]
Patch

Clearing flags on attachment: 360873

Committed r240862: <https://trac.webkit.org/changeset/240862>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

Can this be moved to platform-specific code, e.g. WebPageCocoa.mm? GTK requires the ability to turn it off. References:

https://gitlab.gnome.org/GNOME/epiphany/commit/1618a34e7b66947a4cbcda39870a6fa525dc3a92
https://gitlab.gnome.org/GNOME/epiphany/commit/f0ccff59b66f411a2183a5d716549d14f7f71c81

[Simon Fraser (smfr)]

Is that the same thing? The "Accelerated compositing" setting is about whether RenderLayerCompositor makes RenderLayerBackings for things. Those may still be backed by non-GPU-rendered buffers.

How does Epiphany do rendering with WebKit2?

[Michael Catanzaro]

(In reply to Simon Fraser (smfr) from comment #6)
> Is that the same thing?

Yes, you can verify that our public API webkit_settings_get_hardware_acceleration_policy/webkit_settings_set_hardware_acceleration_policy is implemented by toggling this acceleratedCompositingEnabled setting (as well as the forceCompositingMode setting).

> The "Accelerated compositing" setting is about
> whether RenderLayerCompositor makes RenderLayerBackings for things. Those
> may still be backed by non-GPU-rendered buffers.
> 
> How does Epiphany do rendering with WebKit2?

I don't know anything about this.

[Simon Fraser (smfr)]

(In reply to Michael Catanzaro from comment #7)
> I don't know anything about this.

Who does?

[Michael Catanzaro]

Zan or Miguel, both are CCed.

Anyway, I'll just add #if PLATFORM(COCOA) guards for now.

[Michael Catanzaro]

Committed r240920: <https://trac.webkit.org/changeset/240920>

[Zan Dobersek]

(In reply to Michael Catanzaro from comment #9)
> Zan or Miguel, both are CCed.
> 

DrawingAreaImpl::display(), it draws through FrameView::paint() into a shareable bitmap that's then used in the UIProcess to draw content.

> Anyway, I'll just add #if PLATFORM(COCOA) guards for now.

Since all this is only the case for the GTK+ port, #if !PLATFORM(GTK) guards would be more fitting.

[Michael Catanzaro]

Committed r240937: <https://trac.webkit.org/changeset/240937>

[Simon Fraser (smfr)]

Thanks for fixing.