Bug 194140 - [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
Summary: [iOS] Consistent 1 sec hang when triggering modal alerts while handling synch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-31 22:11 PST by Wenson Hsieh
Modified: 2019-02-01 15:12 PST (History)
7 users (show)

See Also:


Attachments
WIP (29.07 KB, patch)
2019-01-31 22:16 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.59 MB, application/zip)
2019-01-31 23:37 PST, Build Bot
no flags Details
Patch (40.28 KB, patch)
2019-02-01 10:30 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.45 MB, application/zip)
2019-02-01 12:30 PST, Build Bot
no flags Details
Patch (42.94 KB, patch)
2019-02-01 13:32 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-01-31 22:11:31 PST
To reproduce:

1. Go to https://whsieh.github.io/examples/alert
2. Tap on either button

Expected: modal UI should pop up immediately
Observed: 1 second hang before showing modal UI
Comment 1 Radar WebKit Bug Importer 2019-01-31 22:13:04 PST
<rdar://problem/47728098>
Comment 2 Wenson Hsieh 2019-01-31 22:16:35 PST Comment hidden (obsolete)
Comment 3 Build Bot 2019-01-31 23:37:26 PST Comment hidden (obsolete)
Comment 4 Build Bot 2019-01-31 23:37:28 PST Comment hidden (obsolete)
Comment 5 Wenson Hsieh 2019-02-01 10:30:04 PST Comment hidden (obsolete)
Comment 6 Tim Horton 2019-02-01 11:53:38 PST
Comment on attachment 360871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360871&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:740
> +        m_page.cancelGesturesBlockedOnSynchronousReplies();

Do the thing we talked about on IRC (sendSyncWithDelayedReply)
Comment 7 Build Bot 2019-02-01 12:30:18 PST Comment hidden (obsolete)
Comment 8 Build Bot 2019-02-01 12:30:19 PST Comment hidden (obsolete)
Comment 9 Wenson Hsieh 2019-02-01 13:32:29 PST
Created attachment 360892 [details]
Patch
Comment 10 Tim Horton 2019-02-01 14:12:30 PST
Comment on attachment 360892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360892&action=review

> Tools/WebKitTestRunner/TestController.cpp:334
> +        runJavaScriptAlert,

How did we not have this!
Comment 11 WebKit Commit Bot 2019-02-01 15:12:20 PST
Comment on attachment 360892 [details]
Patch

Clearing flags on attachment: 360892

Committed r240882: <https://trac.webkit.org/changeset/240882>
Comment 12 WebKit Commit Bot 2019-02-01 15:12:21 PST
All reviewed patches have been landed.  Closing bug.