Bug 194140 – [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

To reproduce:

1. Go to https://whsieh.github.io/examples/alert
2. Tap on either button

Expected: modal UI should pop up immediately
Observed: 1 second hang before showing modal UI

[Radar WebKit Bug Importer]

<rdar://problem/47728098>

[Wenson Hsieh]

Created attachment 360832 [details]
WIP

[EWS Watchlist]

Comment on attachment 360832 [details]
WIP

Attachment 360832 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10988074

New failing tests:
fast/frames/frame-dead-region.html
pointer-lock/lock-lost-on-alert.html

[EWS Watchlist]

Created attachment 360843 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Wenson Hsieh]

Created attachment 360871 [details]
Patch

[Tim Horton]

Comment on attachment 360871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360871&action=review

> Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:740
> +        m_page.cancelGesturesBlockedOnSynchronousReplies();

Do the thing we talked about on IRC (sendSyncWithDelayedReply)

[EWS Watchlist]

Comment on attachment 360871 [details]
Patch

Attachment 360871 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10996414

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall.https.html

[EWS Watchlist]

Created attachment 360884 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Wenson Hsieh]

Created attachment 360892 [details]
Patch

[Tim Horton]

Comment on attachment 360892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360892&action=review

> Tools/WebKitTestRunner/TestController.cpp:334
> +        runJavaScriptAlert,

How did we not have this!

[WebKit Commit Bot]

Comment on attachment 360892 [details]
Patch

Clearing flags on attachment: 360892

Committed r240882: <https://trac.webkit.org/changeset/240882>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.