Bug 194138 - Remove remaining poisoning code.
Summary: Remove remaining poisoning code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-31 20:24 PST by Mark Lam
Modified: 2019-02-26 23:51 PST (History)
12 users (show)

See Also:


Attachments
proposed patch. (255.59 KB, patch)
2019-01-31 20:44 PST, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (265.20 KB, patch)
2019-01-31 21:04 PST, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (265.17 KB, patch)
2019-01-31 21:15 PST, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (270.18 KB, patch)
2019-01-31 22:14 PST, Mark Lam
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-highsierra (398.64 KB, application/zip)
2019-01-31 23:17 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (424.56 KB, application/zip)
2019-01-31 23:24 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews113 for mac-highsierra (375.65 KB, application/zip)
2019-01-31 23:26 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (651.69 KB, application/zip)
2019-02-01 00:02 PST, EWS Watchlist
no flags Details
proposed patch. (135.26 KB, patch)
2019-02-26 22:27 PST, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (135.26 KB, patch)
2019-02-26 22:28 PST, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-01-31 20:24:34 PST
We no longer do poisoning.  Let's remove the code.
Comment 1 Mark Lam 2019-01-31 20:44:27 PST
Created attachment 360825 [details]
proposed patch.

Let's try this on the EWS.
Comment 2 Mark Lam 2019-01-31 21:04:42 PST
Created attachment 360828 [details]
proposed patch.

Let's try on the EWS again.
Comment 3 Mark Lam 2019-01-31 21:15:15 PST
Created attachment 360829 [details]
proposed patch.
Comment 4 Mark Lam 2019-01-31 22:14:54 PST
Created attachment 360831 [details]
proposed patch.
Comment 5 EWS Watchlist 2019-01-31 23:17:45 PST
Comment on attachment 360831 [details]
proposed patch.

Attachment 360831 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10987890

Number of test failures exceeded the failure limit.
Comment 6 EWS Watchlist 2019-01-31 23:17:47 PST
Created attachment 360836 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 7 EWS Watchlist 2019-01-31 23:24:23 PST
Comment on attachment 360831 [details]
proposed patch.

Attachment 360831 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10987907

Number of test failures exceeded the failure limit.
Comment 8 EWS Watchlist 2019-01-31 23:24:25 PST
Created attachment 360837 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 9 EWS Watchlist 2019-01-31 23:26:20 PST
Comment on attachment 360831 [details]
proposed patch.

Attachment 360831 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10987814

Number of test failures exceeded the failure limit.
Comment 10 EWS Watchlist 2019-01-31 23:26:22 PST
Created attachment 360839 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 11 EWS Watchlist 2019-02-01 00:02:04 PST
Comment on attachment 360831 [details]
proposed patch.

Attachment 360831 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10988033

Number of test failures exceeded the failure limit.
Comment 12 EWS Watchlist 2019-02-01 00:02:05 PST
Created attachment 360844 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 13 Mark Lam 2019-02-26 22:27:29 PST
Created attachment 363072 [details]
proposed patch.

Let's try this on the EWS.
Comment 14 Mark Lam 2019-02-26 22:28:56 PST
Created attachment 363073 [details]
proposed patch.

Let's try attaching the same patch again to see if we can get all the EWS bots to run instead of a reduced set.
Comment 15 Mark Lam 2019-02-26 22:31:18 PST
Comment on attachment 363073 [details]
proposed patch.

I guess the EWS is misbehaving right now.  I'll run the tests locally.  Let's get a review.
Comment 16 Mark Lam 2019-02-26 23:50:53 PST
Thanks for the review.  Landed in r242127: <http://trac.webkit.org/r242127>.
Comment 17 Radar WebKit Bug Importer 2019-02-26 23:51:27 PST
<rdar://problem/48429566>