Bug 194133 - run-webkit-tests emits message "...running None" when running tests
Summary: run-webkit-tests emits message "...running None" when running tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-31 18:30 PST by Daniel Bates
Modified: 2019-02-05 10:33 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.41 KB, patch)
2019-02-05 09:12 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-01-31 18:30:57 PST
Noticed from the output in bug 193857, comment 0, paraphrasing:

[[
[[
$ Tools/Scripts/run-webkit-tests --no-build --debug --ios-simulator LayoutTests/fast/events/ios/keypress-keys-in-non-editable-element.html 
Using port 'ios-simulator'
Test configuration: <, x86_64, debug>
Placing test results in /Volumes/.../Debug-iphonesimulator/layout-test-results
Using Debug build
Pixel tests disabled
Regular timeout: 30000, slow test timeout: 150000
Command line: /Volumes/.../Debug-iphonesimulator/WebKitTestRunnerApp.app -

--lint-test-files warnings:                                    
LayoutTests/platform/ios/TestExpectations:12 Path does not exist. media/controls/ipad

--lint-test-files warnings:                        
LayoutTests/platform/ios/TestExpectations:12 Path does not exist. media/controls/ipad

Found 1 test; running 1, skipping 0.
                  
Verbose baseline search path: platform/ipad-(6th generation)-...-wk2 -> platform/ipad-(6th generation)-... -> platform/ipad-(6th generation)-simulator-wk2 -> platform/ipad-(6th generation)-simulator -> platform/ipad-...-wk2 -> platform/ipad-... -> platform/ipad-simulator-wk2 -> platform/ipad-simulator -> platform/ios-...-wk2 -> platform/ios-... -> platform/ios-simulator-wk2 -> platform/ios-simulator -> platform/ipad-(6th generation)-...-wk2 -> platform/ipad-(6th generation)-... -> platform/ipad-(6th generation)-wk2 -> platform/ipad-(6th generation) -> platform/ipad-...-wk2 -> platform/ipad-... -> platform/ipad-wk2 -> platform/ipad -> platform/ios-...-wk2 -> platform/ios-... -> platform/ios-wk2 -> platform/ios -> platform/wk2 -> generic

Baseline search path: platform/ios-simulator-wk2 -> platform/ios-simulator -> platform/ipad -> platform/ios-wk2 -> platform/ios -> platform/wk2 -> generic

Running 1 test for iPad (6th generation) running None

Running 1 WebKitTestRunnerApp.app.

[1/1] fast/events/ios/keypress-keys-in-non-editable-element.html failed unexpectedly (text diff)

Retrying 1 unexpected failure ...

Running 1 WebKitTestRunnerApp.app.
]]

Notice the "Running 1 test for iPad (6th generation) running None" line. Specifically, the "... running None" part of the line. What does this mean? Doesn't read right.
Comment 1 Radar WebKit Bug Importer 2019-01-31 18:31:44 PST
<rdar://problem/47724738>
Comment 2 Radar WebKit Bug Importer 2019-01-31 18:31:46 PST
<rdar://problem/47724739>
Comment 3 Jonathan Bedard 2019-02-01 08:40:01 PST
I agree that the 'running None' is silly (it should be running iOS <version>). I've seen this effect on-device testing as well.

It's most likely a failure to define the OS when picking up booted devices.
Comment 4 Jonathan Bedard 2019-02-05 09:03:56 PST
Actually, looks like this is really about problems with future versions. It's a pretty simple fix.
Comment 5 Jonathan Bedard 2019-02-05 09:12:18 PST
Created attachment 361195 [details]
Patch
Comment 6 WebKit Commit Bot 2019-02-05 10:33:46 PST
Comment on attachment 361195 [details]
Patch

Clearing flags on attachment: 361195

Committed r240982: <https://trac.webkit.org/changeset/240982>
Comment 7 WebKit Commit Bot 2019-02-05 10:33:48 PST
All reviewed patches have been landed.  Closing bug.