Bug 194130 – Remove invalid assertion in DFG's compileDoubleRep().

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Also remove an invalid assertion in DFG's compileDoubleRep().

<rdar://problem/47699474>

[Mark Lam]

Created attachment 360815 [details]
proposed patch.

[Saam Barati]

Comment on attachment 360815 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=360815&action=review

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:793
> +                    m_graph.convertToConstant(node, JSValue(node->child1()->asNumber()));

do we need purifyNaN here?

[Saam Barati]

Comment on attachment 360815 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=360815&action=review

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:792
> +                if (node->child1()->isNumberConstant()) {

You should put this in AI.

[Saam Barati]

Comment on attachment 360815 [details]
proposed patch.

r=me to remove the assert. It's worth figuring out why the already present rule in AI isn't working.

[EWS Watchlist]

Comment on attachment 360815 [details]
proposed patch.

Attachment 360815 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/10985070

New failing tests:
stress/op_add.js.misc-ftl-no-cjit
stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager-no-cjit
apiTests

[Mark Lam]

(In reply to Saam Barati from comment #4)
> Comment on attachment 360815 [details]
> proposed patch.
> 
> r=me to remove the assert. It's worth figuring out why the already present
> rule in AI isn't working.

OK, I'm just going to remove the assertion in this patch.  Will look into the DoubleRep constant folding issue in https://bugs.webkit.org/show_bug.cgi?id=194165.

[Mark Lam]

Created attachment 360877 [details]
patch for landing.

[WebKit Commit Bot]

Comment on attachment 360877 [details]
patch for landing.

Clearing flags on attachment: 360877

Committed r240878: <https://trac.webkit.org/changeset/240878>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.