Bug 194125 – [WebGPU] Fix GPURenderPassEncoder::setVertexBuffers and allow overlapping indices with GPUBindGroups

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Justin Fan]

[WebGPU] Fix GPURenderPassEncoder::setVertexBuffers and allow overlapping indices with GPUBindGroups

[Justin Fan]

<rdar://problem/46289645>

[Justin Fan]

Created attachment 360811 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 360811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360811&action=review

> Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLVertexBufferIndexCalculator.h:42
> +} // namespace Metal
> +
> +} // namespace WHLSL
> +
> +} // namespace WebCore

Ending comments unnecessary when the file is so short

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:108
> +    [m_platformRenderPassEncoder setVertexBuffers:mtlBuffers.data() offsets:(const NSUInteger *)offsets.data() withRange:indexRanges];

wow

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:33
> +#import "WHLSLVertexBufferIndexCalculator.h"

👍

[WebKit Commit Bot]

Comment on attachment 360811 [details]
Patch

Clearing flags on attachment: 360811

Committed r240898: <https://trac.webkit.org/changeset/240898>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

*** Bug 194182 has been marked as a duplicate of this bug. ***

[Justin Fan]

<rdar://problem/47393543>