Bug 194122 - Capture state should be managed consistently when doing process swapping
Summary: Capture state should be managed consistently when doing process swapping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-31 16:30 PST by youenn fablet
Modified: 2019-02-04 09:37 PST (History)
6 users (show)

See Also:

Attachments
Patch (12.06 KB, patch)
2019-01-31 16:40 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (32.01 KB, patch)
2019-02-01 11:08 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (19.91 KB, patch)
2019-02-01 11:17 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (17.63 KB, patch)
2019-02-01 12:58 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (18.71 KB, patch)
2019-02-01 13:30 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (16.57 KB, patch)
2019-02-01 14:12 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (16.56 KB, patch)
2019-02-01 14:13 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (16.61 KB, patch)
2019-02-01 14:44 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-01-31 16:30:42 PST 
Capture state should be kept consistently when doing process swapping
Comment 1 youenn fablet 2019-01-31 16:30:57 PST 
<rdar://problem/47609293>
Comment 2 youenn fablet 2019-01-31 16:40:48 PST 
Created attachment 360804 [details]
Patch
Comment 3 youenn fablet 2019-02-01 11:08:40 PST 
Created attachment 360874 [details]
Patch
Comment 4 EWS Watchlist 2019-02-01 11:12:21 PST 
Attachment 360874 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4700:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4708:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 youenn fablet 2019-02-01 11:17:38 PST 
Created attachment 360875 [details]
Patch
Comment 6 EWS Watchlist 2019-02-01 11:19:39 PST 
Attachment 360875 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4700:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4708:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 youenn fablet 2019-02-01 12:58:52 PST 
Created attachment 360885 [details]
Patch
Comment 8 EWS Watchlist 2019-02-01 13:00:33 PST 
Attachment 360885 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4700:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4708:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 youenn fablet 2019-02-01 13:30:13 PST 
Created attachment 360891 [details]
Patch
Comment 10 EWS Watchlist 2019-02-01 13:32:38 PST 
Attachment 360891 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4700:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4708:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 youenn fablet 2019-02-01 14:12:45 PST 
Created attachment 360895 [details]
Patch
Comment 12 youenn fablet 2019-02-01 14:13:52 PST 
Created attachment 360896 [details]
Patch
Comment 13 EWS Watchlist 2019-02-01 14:15:55 PST 
Attachment 360896 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4700:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4708:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 youenn fablet 2019-02-01 14:44:17 PST 
Created attachment 360906 [details]
Patch
Comment 15 EWS Watchlist 2019-02-01 14:47:14 PST 
Attachment 360906 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4700:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4708:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 WebKit Commit Bot 2019-02-04 09:37:07 PST 
Comment on attachment 360906 [details]
Patch

Clearing flags on attachment: 360906

Committed r240928: <https://trac.webkit.org/changeset/240928>
Comment 17 WebKit Commit Bot 2019-02-04 09:37:09 PST 
All reviewed patches have been landed.  Closing bug.