RESOLVED FIXED 194119
Web Inspector: Make WI.StackedLineChart a WI.View subclass 
https://bugs.webkit.org/show_bug.cgi?id=194119
Summary Web Inspector: Make WI.StackedLineChart a WI.View subclass
Joseph Pecoraro
Reported 2019-01-31 15:36:44 PST
Make WI.StackedLineChart a WI.View subclass It can eliminate its own needsLayout/updateLayout logic and participate in normal view drawing. Note: - LineChart just moved as well.
Attachments
[PATCH] Proposed Fix (5.74 KB, patch)
2019-01-31 15:37 PST, Joseph Pecoraro 		hi: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-01-31 15:37:48 PST
Created attachment 360796 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 2 2019-01-31 17:51:34 PST
Comment on attachment 360796 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=360796&action=review rs=me, not sure why this won't apply 🤔, but it looks good to me > Source/WebInspectorUI/UserInterface/Views/LineChart.js:91 > + super.layout(); Oops. Forgot that :P > Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.js:43 > + this._chart.size = new WI.Size(0, this.height); I don't think this is necessary, given that you're making the width `0`. Not setting a `size` means we don't draw, so it should have the same effect as setting the width to `0`.
Joseph Pecoraro
Comment 3 2019-02-01 13:27:02 PST
https://trac.webkit.org/changeset/240871/webkit
Radar WebKit Bug Importer
Comment 4 2019-02-01 13:27:28 PST
<rdar://problem/47747265>
Note You need to log in before you can comment on or make changes to this bug.