RESOLVED FIXED194118
Web Inspector: Make WI.CircleChart a WI.View subclass 
https://bugs.webkit.org/show_bug.cgi?id=194118
Summary Web Inspector: Make WI.CircleChart a WI.View subclass
Joseph Pecoraro
Reported 2019-01-31 15:31:24 PST
Make WI.CircleChart a WI.View subclass It can eliminate its own needsLayout/updateLayout logic and participate in normal view drawing.
Attachments
[PATCH] Proposed Fix (6.08 KB, patch)
2019-01-31 15:31 PST, Joseph Pecoraro 		mattbaker: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-01-31 15:31:51 PST
Created attachment 360794 [details] [PATCH] Proposed Fix
Matt Baker
Comment 2 2019-01-31 15:35:22 PST
Comment on attachment 360794 [details] [PATCH] Proposed Fix r=me
Matt Baker
Comment 3 2019-01-31 15:38:21 PST
CircleChart could also implement View.prototype.initalLayout, and then you could lazily create the chart/path elements instead of creating them in the constructor.
Devin Rousso
Comment 4 2019-01-31 15:38:31 PST
Comment on attachment 360794 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=360794&action=review > Source/WebInspectorUI/UserInterface/Views/CircleChart.js:79 > get points() { return this._points; } > get size() { return this._size; } NIT: I think we can drop these as well.
Joseph Pecoraro
Comment 5 2019-02-01 13:26:46 PST
https://trac.webkit.org/changeset/240870/webkit
Radar WebKit Bug Importer
Comment 6 2019-02-01 13:27:28 PST
<rdar://problem/47747266>
Note You need to log in before you can comment on or make changes to this bug.