Bug 194115 - Web Inspector: Timeline Detail Views do not reset properly when new time range selection contains nothing
Summary: Web Inspector: Timeline Detail Views do not reset properly when new time rang...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-31 14:35 PST by Joseph Pecoraro
Modified: 2019-02-01 13:26 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.66 KB, patch)
2019-01-31 14:59 PST, Joseph Pecoraro 		hi: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-01-31 14:35:12 PST 
Timeline Detail Views do not reset properly when new time range selection contains nothing

Steps to Reproduce:
1. Inspect this page
2. Show Memory Timeline
3. Make a short recording
4. Select an empty time range (like 4s-5s)
  => Memory Detail View circle charts still filled

Notes:
- layout() should be resetting instead of bailing
Comment 1 Radar WebKit Bug Importer 2019-01-31 14:35:43 PST 
<rdar://problem/47716693>
Comment 2 Joseph Pecoraro 2019-01-31 14:59:07 PST 
Created attachment 360791 [details]
[PATCH] Proposed Fix
Comment 3 Devin Rousso 2019-01-31 15:15:39 PST 
Comment on attachment 360791 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=360791&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:83
> +        this.clear();

I think this deserves a ChangeLog comment.  Something like "Calling `.clear()` will remove all UI from the selected range, but keep any non-range-specific values (e.g. maximum usage) as they were in the UI.".
Comment 4 Joseph Pecoraro 2019-02-01 13:26:37 PST 
https://trac.webkit.org/changeset/240869/webkit