Bug 194113 - Remove poisoning from CodeBlock and LLInt code.
Summary: Remove poisoning from CodeBlock and LLInt code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-31 14:17 PST by Mark Lam
Modified: 2019-01-31 17:39 PST (History)
6 users (show)

See Also:

Attachments
proposed patch. (19.56 KB, patch)
2019-01-31 14:21 PST, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing. (23.50 KB, patch)
2019-01-31 15:10 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-01-31 14:17:33 PST 
Poisoning is no longer needed.
Comment 1 Mark Lam 2019-01-31 14:21:23 PST 
Created attachment 360781 [details]
proposed patch.
Comment 2 EWS Watchlist 2019-01-31 14:25:03 PST 
Attachment 360781 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:374:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2019-01-31 14:37:31 PST 
Comment on attachment 360781 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=360781&action=review

r=me with some suggestions.

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:535
> +    loadp CodeBlock::m_vm[scratch], scratch

scratch2 is no longer necessary.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:-1037
> -    unpoison(_g_JSFunctionPoison, targetRegister, scratch)

scratch is no longer necessary.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:-1049
> -    unpoison(_g_JSFunctionPoison, targetRegister, scratch)

Ditto.
Comment 4 Mark Lam 2019-01-31 15:10:14 PST 
Created attachment 360793 [details]
patch for landing.

Thanks for the feedback.  I've removed the unneeded scratch registers.
Comment 5 EWS Watchlist 2019-01-31 15:13:01 PST 
Attachment 360793 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:374:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Mark Lam 2019-01-31 17:38:26 PST 
Landed in r240832: <http://trac.webkit.org/r240832>.
Comment 7 Radar WebKit Bug Importer 2019-01-31 17:39:29 PST 
<rdar://problem/47723400>