Bug 194112 - testapi fails RELEASE_ASSERT(codeBlock) in fetchFromDisk() of CodeCache.h.
Summary: testapi fails RELEASE_ASSERT(codeBlock) in fetchFromDisk() of CodeCache.h.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-31 13:51 PST by Mark Lam
Modified: 2019-01-31 14:20 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2019-01-31 14:03 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-01-31 13:51:25 PST 
$ ./Tools/Scripts/run-javascriptcore-tests --debug --no-build --testapi

...
2019-01-31 13:48:47.394 testapi[22701:3219904] TEST: "Promise was resolved": PASSED
ASSERTION FAILED: codeBlock
./runtime/CodeCache.h(172) : std::enable_if_t<std::is_base_of<UnlinkedCodeBlock, UnlinkedCodeBlockType>::value && !std::is_same<UnlinkedCodeBlockType, UnlinkedEvalCodeBlock>::value, UnlinkedCodeBlockType *> JSC::CodeCacheMap::fetchFromDisk(JSC::VM &, const JSC::SourceCodeKey &) [UnlinkedCodeBlockType = JSC::UnlinkedProgramCodeBlock]
1   0x10f05a589 WTFCrash
2   0x10f05b57b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x110475cca std::__1::enable_if<(std::is_base_of<JSC::UnlinkedCodeBlock, JSC::UnlinkedProgramCodeBlock>::value) && (!(std::is_same<JSC::UnlinkedProgramCodeBlock, JSC::UnlinkedEvalCodeBlock>::value)), JSC::UnlinkedProgramCodeBlock*>::type JSC::CodeCacheMap::fetchFromDisk<JSC::UnlinkedProgramCodeBlock>(JSC::VM&, JSC::SourceCodeKey const&)
4   0x11047575d JSC::UnlinkedProgramCodeBlock* JSC::CodeCacheMap::findCacheAndUpdateAge<JSC::UnlinkedProgramCodeBlock>(JSC::VM&, JSC::SourceCodeKey const&)
5   0x110442355 JSC::UnlinkedProgramCodeBlock* JSC::CodeCache::getUnlinkedGlobalCodeBlock<JSC::UnlinkedProgramCodeBlock, JSC::ProgramExecutable>(JSC::VM&, JSC::ProgramExecutable*, JSC::SourceCode const&, JSC::JSParserStrictMode, JSC::JSParserScriptMode, JSC::DebuggerMode, JSC::ParserError&, JSC::EvalContextType)
6   0x110442178 JSC::CodeCache::getUnlinkedProgramCodeBlock(JSC::VM&, JSC::ProgramExecutable*, JSC::SourceCode const&, JSC::JSParserStrictMode, JSC::DebuggerMode, JSC::ParserError&)
7   0x11068669a JSC::ProgramExecutable::initializeGlobalProperties(JSC::VM&, JSC::ExecState*, JSC::JSScope*)
8   0x110188fc1 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::ExecState*, JSC::JSObject*)
9   0x1104942c5 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
10  0x110494481 JSC::profiledEvaluate(JSC::ExecState*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
11  0x10f6334bf JSEvaluateScript
12  0x10f550ec4 -[JSContext evaluateScript:withSourceURL:]
13  0x10ef974d3 testBytecodeCache()
14  0x10ef961ed testObjectiveCAPI
15  0x10ef7fed2 main
16  0x7fff6bd633ed start
testapi completed with rc=11 (254)
Comment 1 Mark Lam 2019-01-31 13:52:15 PST 
This was seen with trunk r240812.
Comment 2 Tadeu Zagallo 2019-01-31 14:03:49 PST 
Created attachment 360772 [details]
Patch
Comment 3 Mark Lam 2019-01-31 14:04:53 PST 
Comment on attachment 360772 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-01-31 14:19:58 PST 
Comment on attachment 360772 [details]
Patch

Clearing flags on attachment: 360772

Committed r240820: <https://trac.webkit.org/changeset/240820>
Comment 5 WebKit Commit Bot 2019-01-31 14:19:59 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-01-31 14:20:26 PST 
<rdar://problem/47716074>